Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NIX_CONFIG env var for applying nix.conf overrides #4166

Merged
merged 1 commit into from Oct 21, 2020

Conversation

@kampka
Copy link
Contributor

@kampka kampka commented Oct 19, 2020

This PR offers an alternative approach of providing nix config settings via environment variables as propose by edolstra in #4163

@zimbatm
Copy link
Member

@zimbatm zimbatm commented Oct 19, 2020

Make sure to add some test in tests/config.sh and document it in doc/manual/command-ref/env-common.xml and doc/manual/command-ref/conf-file.xml

@kampka
Copy link
Contributor Author

@kampka kampka commented Oct 20, 2020

@zimbatm done

@edolstra
Copy link
Member

@edolstra edolstra commented Oct 21, 2020

Can you rebase on master where conf-file.xml is gone?

@kampka
Copy link
Contributor Author

@kampka kampka commented Oct 21, 2020

Can you rebase on master where conf-file.xml is gone?

Done

@kampka
Copy link
Contributor Author

@kampka kampka commented Oct 21, 2020

@edolstra looks like the conf-file.xml is still on master though.

@edolstra
Copy link
Member

@edolstra edolstra commented Oct 21, 2020

Sorry, I pushed to the wrong branch. It's fixed now (bdf2bcc).

@edolstra edolstra merged commit ecfebde into NixOS:master Oct 21, 2020
2 checks passed
@kampka
Copy link
Contributor Author

@kampka kampka commented Oct 21, 2020

Thanks for the expedient reviews 👍

@knedlsepp
Copy link
Member

@knedlsepp knedlsepp commented Oct 21, 2020

Could it be that something went wrong here with the docs? It mentions NIX_OPTIONS while the code uses NIX_CONFIG. (#4177)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants