Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iterating over $NIX_PROFILES in Zsh #4171

Merged
merged 1 commit into from Nov 17, 2020
Merged

Conversation

@YorikSar
Copy link
Contributor

@YorikSar YorikSar commented Oct 20, 2020

NIX_PROFILES is space separated list of directories, and passing it into
for as is is considered to be 1-element list with the whole string. With
shwordsplit option Zsh emulates other shells in this regard ans
implicitely splits unquoted strings into words.

Fixes #4167.

NIX_PROFILES is space separated list of directories, and passing it into
for as is is considered to be 1-element list with the whole string. With
shwordsplit option Zsh emulates other shells in this regard ans
implicitely splits unquoted strings into words.

Fixes NixOS#4167.
@jdheyburn
Copy link

@jdheyburn jdheyburn commented Oct 26, 2020

I was experiencing the error in the linked issue, and only on manually applying this change did it work, so thank you for the PR 🎉 .

For anyone stumbling on this before it is released, I manually altered this file for the fix: /nix/var/nix/profiles/default/etc/profile.d/nix-daemon.sh

regnat
regnat approved these changes Nov 6, 2020
@edolstra edolstra merged commit ae31916 into NixOS:master Nov 17, 2020
2 checks passed
@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented May 12, 2021

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/when-will-new-stable-nix-version-with-bug-fixes-be-released/13022/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants