Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix develop --phase: chdir to flake directory #4176

Merged
merged 1 commit into from Sep 8, 2021
Merged

Conversation

@mkenigs
Copy link
Contributor

@mkenigs mkenigs commented Oct 21, 2020

For git+file and path flakes, chdir to flake directory so that phases
that expect to be in the flake directory can run

Fixes #3976

Personally I feel like this is kind of hacky to make exceptions for just git+file and path flakes, which is part of why I think what develop does should be clarified (#4170) But it is convenient for this to work

@stale
Copy link

@stale stale bot commented Jun 2, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the stale label Jun 2, 2021
src/nix/develop.cc Outdated Show resolved Hide resolved
@stale stale bot removed the stale label Jul 15, 2021
@mkenigs mkenigs force-pushed the fix-3976 branch 3 times, most recently from 3904e28 to ba6ad37 Jul 23, 2021
For git+file and path flakes, chdir to flake directory so that phases
that expect to be in the flake directory can run

Fixes NixOS#3976
@mkenigs
Copy link
Contributor Author

@mkenigs mkenigs commented Sep 8, 2021

@regnat this look good now?

@edolstra edolstra merged commit b71428c into NixOS:master Sep 8, 2021
6 checks passed
6 checks passed
@github-actions[bot]
tests (ubuntu-latest)
Details
@github-actions[bot]
tests (macos-latest)
Details
@github-actions[bot]
Cachix secret present for installer tests
Details
@github-actions[bot]
installer
Details
@github-actions[bot]
installer_test
Details
@dpulls[bot]
dpulls All dependencies are resolved.
Details
@edolstra
Copy link
Member

@edolstra edolstra commented Sep 8, 2021

@mkenigs Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants