Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dir attribute to output argument if input specified dir. #4291

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

@kquick
Copy link
Contributor

@kquick kquick commented Nov 29, 2020

If the input url specifies a dir component, this PR ensures that dir
specification is passed as an attribute on the argument provided to
the output function for that input:

inputs.foo.url = "https://github.com/group/proj?dir=sub/dir";
outputs = { self, foo }:
    assert foo.dir == "sub/dir"; ...

This is useful for various library functions and other operations that
need to know if the input specified a subdirectory relative to the
fetch.

If the input url specifies a dir component, this PR ensures that dir
specification is passed as an attribute on the argument provided to
the output function for that input:

    inputs.foo.url = "https://github.com/group/proj?dir=sub/dir";
    outputs = { self, foo }:
        assert foo.dir == "sub/dir"; ...

This is useful for various library functions and other operations that
need to know if the input specified a subdirectory relative to the
fetch.
@kquick
Copy link
Contributor Author

@kquick kquick commented Feb 16, 2021

@edolstra This is ready for review and merge.

@stale
Copy link

@stale stale bot commented Aug 17, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the stale label Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant