Log ssh output for ssh-ng too #5014
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think this was just an oversight. Right now, ssh:// gets ssh errors but not ssh-ng://. /cc @edolstra
thufschmitt
approved these changes
Jul 15, 2021
Ericson2314
reviewed
Jul 27, 2021
Comment on lines
+27
to
+30
| // Hack for getting remote build log output. | ||
| // Intentionally not in `SSHStoreConfig` so that it doesn't appear in | ||
| // the documentation | ||
| const Setting<int> logFD{(StoreConfig*) this, -1, "log-fd", "file descriptor to which SSH's stderr is connected"}; |
There was a problem hiding this comment.
N.B. this seems sketch, but is actually fine because this is exactly how LegacySSHStore does it.
Ericson2314
approved these changes
Jul 27, 2021
|
I think the reason why |
|
Closing as described above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this was just an oversight. Right now, ssh:// gets ssh errors but not ssh-ng://.
/cc @edolstra