Make profile element names stable #9656
Conversation
The profile manifest is now an object keyed on the name returned by getNameFromURL() at installation time, instead of an array. This ensures that the names of profile elements don't change when other elements are added/removed.
github-actions
bot
added
documentation
with-tests
AFAIK, we've never emitted this attribute.
There was a problem hiding this comment.
I tried it. Upgrades the manifest.json upon making changes quite nicely.
One issue I ran into was the URL that was used for getNameFromURL. Instead of github:nixos/nixpkgs/nixpkgs-unstable#hello it now passes github:nixos/nixpkgs/nixpkgs-unstable#legacyPackages.x86_64-linux.hello. Unfortunately getNameFromURL doesn't support legacyPackages and there are no tests for this as well. The resulting entry is named legacyPackages.x86_64-linux.hello. Unrelated to this PR, but it did expose the problem for me. I've created edolstra#9 to support legacyPackages.
Apart from that, I didn't run into trouble with my profile/manifest. I do wonder whether the migration from manifest version 2 to 3 should have a test?
Btw, I'm on vacation for the next week, so expect my feedback after that.
|
This should have a release note indicating that it changes the profile format, and previous versions will not be able to parse it anymore. |
|
Updated the release notes and added a migration test. |
Based off of commit 3187bc9 Upstream-PR: NixOS/nix#9656 Co-authored-by: Eelco Dolstra <edolstra@gmail.com> Change-Id: I8ac4a33314cd1cf9de95404c20f58e883460acc7
Based off of commit 6268a45 Upstream-PR: NixOS/nix#9656 Co-authored-by: Eelco Dolstra <edolstra@gmail.com> Change-Id: I0fcf069a8537c61ad6fc4eee1f3c193a708ea1c4
(cherry picked from commit 72560f7) Upstream-PR: NixOS/nix#9656 Change-Id: I405e5848e2627a76940220fb6aebadfb8f094afb
It doesn't seem to have ever been used. Based off of commit a748e88 Upstream-PR: NixOS/nix#9656 Change-Id: Idcf250a645fa43f2ef11fb15b503b070a62a917e
Based off of commit 3187bc9 Upstream-PR: NixOS/nix#9656 Co-authored-by: Eelco Dolstra <edolstra@gmail.com> Change-Id: I8ac4a33314cd1cf9de95404c20f58e883460acc7
Based off of commit 6268a45 Upstream-PR: NixOS/nix#9656 Co-authored-by: Eelco Dolstra <edolstra@gmail.com> Change-Id: I0fcf069a8537c61ad6fc4eee1f3c193a708ea1c4
(cherry picked from commit 72560f7) Upstream-PR: NixOS/nix#9656 Change-Id: I405e5848e2627a76940220fb6aebadfb8f094afb
It doesn't seem to have ever been used. Based off of commit a748e88 Upstream-PR: NixOS/nix#9656 Change-Id: Idcf250a645fa43f2ef11fb15b503b070a62a917e
Motivation
The profile manifest is now an object keyed on the name returned by
getNameFromURL()at installation time, instead of an array. This ensures that the names of profile elements don't change when other elements are added/removed.It also removes profile element indices entirely.
Followup to #8678.
Context
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.