Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poetry2nixify nixops_aws #101

Merged
merged 4 commits into from May 21, 2020
Merged

Poetry2nixify nixops_aws #101

merged 4 commits into from May 21, 2020

Conversation

@tewfik-ghariani
Copy link
Contributor

tewfik-ghariani commented May 5, 2020

Getting nixops_aws up to speed in regards to using Poetry as dependency manager ( Ref : NixOS/nixops#1256 )

Authoring guidelines : https://github.com/NixOS/nixops/blob/master/doc/plugins/authoring.rst

Note that there has been a recent PR merged in nixops which broke all plugins. NixOS/nixops#1275 has as a goal to switch the representation from xml->json

As a result, fixed the nixops revision in pyproject.toml to NixOS/nixops@ab0780d for now

cc @grahamc @adisbladis

@adisbladis
Copy link
Member

adisbladis commented May 21, 2020

We are working on top of this PR to fix compatibilty with NixOps master. Since the current nixops-aws doesn't work on NixOps master anyway there is no harm in merging this and making progress on the new work easier.

Therefore I'm merging this, despite not fully making nixops-aws compatible.

@adisbladis adisbladis merged commit 2d644de into NixOS:master May 21, 2020
2 checks passed
2 checks passed
build
Details
black
Details
@tewfik-ghariani
Copy link
Contributor Author

tewfik-ghariani commented May 22, 2020

Thanks @adisbladis
Please note that the 'check' operation is still failing using this nixops revision as the fix was merged afterwards per NixOS/nixops#1334

@tewfik-ghariani tewfik-ghariani deleted the tewfik-ghariani:poetry2nixify branch May 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.