Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add black formatting check to PR validation in CI; switch from Travis to Github Actions #27

Merged
merged 2 commits into from Mar 15, 2020

Conversation

@bhipple
Copy link
Contributor

bhipple commented Mar 15, 2020

Having merged the format updates in #22,
let's add it to pull request validation to ensure we don't backslide.

Note that we could go one step further and add it to the checkPhase of the
python package build, like nixpkgs-review
does; however, doing so would break the build if someone tried to use the
nixops-aws build on 19.09 vs. 20.03 vs. unstable, and since it's a CI/PR only
concept this takes the more gentle approach of just adding it to Travis.

@bhipple bhipple force-pushed the bhipple:feature/formatting-ci branch from d54f81d to e409f03 Mar 15, 2020
.travis.yml Outdated Show resolved Hide resolved
Having merged the format updates in #22,
let's add it to pull request validation to ensure we don't backslide.

Note that we could go one step further and add it to the `checkPhase` of the
python package build, like [nixpkgs-review](https://github.com/Mic92/nixpkgs-review/blob/master/default.nix)
does; however, doing so would break the build if someone tried to use the
`nixops-aws` build on 19.09 vs. 20.03 vs. unstable, and since it's a CI/PR only
concept this takes the more gentle approach of just adding it to Travis.
@bhipple bhipple force-pushed the bhipple:feature/formatting-ci branch from e409f03 to 9a43c90 Mar 15, 2020
@bhipple bhipple changed the title Add black formatting check to PR validation in CI Add black formatting check to PR validation in CI; switch from Travis to Github Actions Mar 15, 2020
@grahamc grahamc merged commit f4937ac into NixOS:master Mar 15, 2020
@bhipple bhipple deleted the bhipple:feature/formatting-ci branch Mar 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.