Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EC2: Adding ec2 hibernation. #1138

Closed
wants to merge 2 commits into from
Closed

Conversation

@PsyanticY
Copy link
Contributor

@PsyanticY PsyanticY commented Apr 25, 2019

To stop hibernate the instance:

nixops  stop -d nixos-test  --hibernate --include test

To stop hibernate a given instance whithin a multi machine network

nixops  stop -d nixos-test  --hibernate --include test
@PsyanticY PsyanticY marked this pull request as ready for review Apr 30, 2019
@PsyanticY
Copy link
Contributor Author

@PsyanticY PsyanticY commented Apr 30, 2019

@AmineChikhaoui Please have a look.

@asymmetric
Copy link
Contributor

@asymmetric asymmetric commented Apr 30, 2019

FYI you can mark PRs as draft when you create them. It's a new feature AFAIK.

@PsyanticY
Copy link
Contributor Author

@PsyanticY PsyanticY commented Apr 30, 2019

@asymmetric yeah thanks :) , it was draft and i just switched it.

@PsyanticY PsyanticY force-pushed the PsyanticY:ec2Hibernation branch from b1c0190 to 65d9ff5 Apr 30, 2019
@PsyanticY PsyanticY changed the title [WIP]: EC2: Adding ec2 hibernation. EC2: Adding ec2 hibernation. Apr 30, 2019
@PsyanticY PsyanticY force-pushed the PsyanticY:ec2Hibernation branch from c5d7072 to 4dc7893 Apr 30, 2019
@PsyanticY PsyanticY force-pushed the PsyanticY:ec2Hibernation branch from 4dc7893 to 226ec83 Apr 30, 2019
@grahamc
Copy link
Member

@grahamc grahamc commented Mar 26, 2020

Hello!

Thank you for this PR.

In the past several months, some major changes have taken place in
NixOps:

  1. Backends have been removed, preferring a plugin-based architecture.
    Here are some of them:

  2. NixOps Core has been updated to be Python 3 only, and at the
    same time, MyPy type hints have been added and are now strictly
    required during CI.

This is all accumulating in to what I hope will be a NixOps 2.0
release
. There is a tracking issue for that:
#1242 . It is possible that
more core changes will be made to NixOps for this release, with a
focus on simplifying NixOps core and making it easier to use and work
on.

My hope is that by adding types and more thorough automated testing,
it will be easier for contributors to make improvements, and for
contributions like this one to merge in the future.

However, because of the major changes, it has become likely that this
PR cannot merge right now as it is. The backlog of now-unmergable PRs
makes it hard to see which ones are being kept up to date.

If you would like to see this merge, please bring it up to date with
master and reopen it
. If the or mypy type checking fails, please
correct any issues and then reopen it. I will be looking primarily at
open PRs whose tests are all green.

Thank you again for the work you've done here, I am sorry to be
closing it now.

Graham

@grahamc grahamc closed this Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.