Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import to state functionality #1178

wants to merge 2 commits into from


Copy link

@PsyanticY PsyanticY commented Jul 8, 2019

No description provided.

Copy link
Contributor Author

@PsyanticY PsyanticY commented Jul 8, 2019

fixes #1129

@PsyanticY PsyanticY changed the title Import functionalities Import to state functionality Jul 8, 2019
Copy link

@asymmetric asymmetric commented Jul 8, 2019

Could you provide an example of how to use this?

Copy link
Contributor Author

@PsyanticY PsyanticY commented Jul 9, 2019

@asymmetric This aims to allow to import existing resources to state by basically using a unique option for each resource (volume id, allocation id, security group id, etc ...)
we will be feeding the deployment classic nix expressions and we need to add (in the case of elastic ip) the address option that is normally set by nixops

  resources.elasticIPs.eip =
      inherit region accessKeyId;
      vpc = true;
      address = "";

The import-to-state function will make call to get the resource description. we make sure it exist and that the other options we passed are correct. finally all the option get written to the state. from this point we can manage the resource as it was created by nixops.
I m working on other resources in the mean time so please let me know if anything can be improved.

Copy link

@grahamc grahamc commented Mar 26, 2020


Thank you for this PR.

In the past several months, some major changes have taken place in

  1. Backends have been removed, preferring a plugin-based architecture.
    Here are some of them:

  2. NixOps Core has been updated to be Python 3 only, and at the
    same time, MyPy type hints have been added and are now strictly
    required during CI.

This is all accumulating in to what I hope will be a NixOps 2.0
. There is a tracking issue for that:
#1242 . It is possible that
more core changes will be made to NixOps for this release, with a
focus on simplifying NixOps core and making it easier to use and work

My hope is that by adding types and more thorough automated testing,
it will be easier for contributors to make improvements, and for
contributions like this one to merge in the future.

However, because of the major changes, it has become likely that this
PR cannot merge right now as it is. The backlog of now-unmergable PRs
makes it hard to see which ones are being kept up to date.

If you would like to see this merge, please bring it up to date with
master and reopen it
. If the or mypy type checking fails, please
correct any issues and then reopen it. I will be looking primarily at
open PRs whose tests are all green.

Thank you again for the work you've done here, I am sorry to be
closing it now.


@grahamc grahamc closed this Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.