Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some niche features #1312

Merged
merged 4 commits into from May 7, 2020
Merged

Remove some niche features #1312

merged 4 commits into from May 7, 2020

Conversation

@adisbladis
Copy link
Member

adisbladis commented Apr 21, 2020

See #1242

Please note that this is not about just removing these features. They will be reintroduced as plugins.

@grahamc
Copy link
Member

grahamc commented Apr 21, 2020

Maybe we should make a repo for useful modules which also don't belong in nixpkgs, and refer to it in a changelog entry?

@grahamc
Copy link
Member

grahamc commented Apr 21, 2020

really nice that they're not actually using any code in nixops itself, and the modules can just be dropped in

@grahamc grahamc changed the title Remove some questionable features Remove some niche features Apr 21, 2020
@nixos-discourse
Copy link

nixos-discourse commented Apr 21, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/tweag-nix-dev-update-2/6808/1

@grahamc grahamc added this to In progress in kanban Apr 23, 2020
@grahamc grahamc moved this from In progress to To do in kanban Apr 23, 2020
@grahamc
Copy link
Member

grahamc commented May 5, 2020

LGTM but let's make that repo and move these expressions over. I asked in #nix-community on IRC about a good repo name for it. Once we do and move the exprs, let's make a link to it from the readme.

@grahamc
Copy link
Member

grahamc commented May 6, 2020

I've split the history of auto-luks and auto-raid0 in to https://github.com/nix-community/nixos-modules-contrib. We probably should have been doing this from the start, but I'll add a changelog entry for this.

@grahamc grahamc force-pushed the adisbladis:feature-removal branch 2 times, most recently from f2106a4 to ca3e4b9 May 6, 2020
@grahamc
grahamc approved these changes May 6, 2020
Copy link
Member

grahamc left a comment

I'd merge but I want you to take a look, @adisbladis first.

@adisbladis
Copy link
Member Author

adisbladis commented May 7, 2020

@grahamc I think we really need a story for how to get https://github.com/nix-community/nixos-modules-contrib into peoples NixOps deployments.
Imo we should make https://github.com/nix-community/nixos-modules-contrib a NixOps plugin.

@grahamc
Copy link
Member

grahamc commented May 7, 2020

That sounds good to me. We might want to get the nixos-infect file a better home, too, while we're at it?

@adisbladis
Copy link
Member Author

adisbladis commented May 7, 2020

That sounds good to me. We might want to get the nixos-infect file a better home, too, while we're at it?

Actually thinking about this a bit more I realised it doesn't make much sense to make the external repo a NixOps plugin as it's not directly tied to NixOps, it's just external NixOps modules.

So my recommendation to users in this instance would be to use Niv, or at a later date Nix flakes.

@adisbladis
Copy link
Member Author

adisbladis commented May 7, 2020

nixos-infect already has another home at https://github.com/elitak/nixos-infect.
We may want to talk to @elitak and get this moved over to https://github.com/nix-community?

@grahamc
Copy link
Member

grahamc commented May 7, 2020

I agree about not doing the plugin, and leaving that for other solutions like niv, flakes, or another mechanism. That said, if someone wanted to make the plugin, that would be great.

adisbladis added 3 commits Apr 21, 2020
Closes #1299
Closes #1297
Closes #1305
@grahamc grahamc force-pushed the adisbladis:feature-removal branch from ca3e4b9 to 6f37f02 May 7, 2020
@grahamc grahamc force-pushed the adisbladis:feature-removal branch from 6f37f02 to 1d06c02 May 7, 2020
@grahamc
Copy link
Member

grahamc commented May 7, 2020

Just did a rebase and trivial fix-up of including the 2.0 notes in the toc, and fixing header's underbars.

@grahamc grahamc merged commit 8907223 into NixOS:master May 7, 2020
9 checks passed
9 checks passed
parsing
Details
build
Details
black
Details
mypy
Details
mypy-ratchet
Details
coverage
Details
docs
Details
poetry-up-to-date
Details
docs/readthedocs.org:nixops Read the Docs build succeeded!
Details
kanban automation moved this from To do to Done May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
kanban
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.