Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore private ipv4 support #1327

Merged
merged 1 commit into from May 5, 2020
Merged

Restore private ipv4 support #1327

merged 1 commit into from May 5, 2020

Conversation

@adisbladis
Copy link
Member

adisbladis commented Apr 28, 2020

This was accidentally removed in de59e48

@grahamc grahamc added this to In progress in kanban May 5, 2020
@grahamc
Copy link
Member

grahamc commented May 5, 2020

I think if we add a type for private_ipv4 and public_ipv4, we'll get the ratchet to pass, and it is sort of in the spirit of the ratchet too. Do you mind doing that?

This was accidentally removed in de59e48
@adisbladis adisbladis force-pushed the adisbladis:private-ipv4 branch from 3c16b5f to 395a237 May 5, 2020
@grahamc
Copy link
Member

grahamc commented May 5, 2020

The ratchet is failing because of this Any:

        attrs_per_resource: Dict[str, List[Dict[Tuple[str, ...], Any]]] = {
            m.name: [] for m in active_resources.values()
        }

and attrs_list has propagated the explicitly annotated Any type. Touching this list twice more is what is causing the problem. It'd be nice to get rid of that Any if we can, but not in this PR. Thanks!

@grahamc grahamc merged commit a0f47c7 into NixOS:master May 5, 2020
5 of 6 checks passed
5 of 6 checks passed
parsing
Details
build
Details
black
Details
mypy
Details
mypy-ratchet mypy-ratchet
Details
coverage
Details
kanban automation moved this from In progress to Done May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
kanban
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.