Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix op_check #1334

Merged
merged 2 commits into from May 1, 2020
Merged

fix op_check #1334

merged 2 commits into from May 1, 2020

Conversation

@manveru
Copy link
Contributor

manveru commented May 1, 2020

No description provided.

@grahamc
grahamc approved these changes May 1, 2020
Copy link
Member

grahamc left a comment

without this:

[nix-shell:~/projects/github.com/NixOS/nixops]$ NIX_PATH="nixpkgs=https://nixos.org/channels/nixos-20.03/nixexprs.tar.xz" nixops check --deployment personal
error: Multiple exceptions (5):
  * fender: Cannot operate on a closed database.
  * flexo: Cannot operate on a closed database.
  * kif: Cannot operate on a closed database.
  * lord-nibbler: Cannot operate on a closed database.
  * ogden: Cannot operate on a closed database.

after:

[nix-shell:~/projects/github.com/NixOS/nixops]$ NIX_PATH="nixpkgs=https://nixos.org/channels/nixos-20.03/nixexprs.tar.xz" nixops check --deploymen
t personal
Machines state:
+--------------+--------+-----+-----------+----------+----------------+----------------------------------------+-------+
| Name         | Exists | Up  | Reachable | Disks OK | Load avg.      | Units                                  | Notes |
+--------------+--------+-----+-----------+----------+----------------+----------------------------------------+-------+
| fender       | Yes    | No  | N/A       | N/A      |                |                                        |       |
| flexo        | Yes    | Yes | Yes       | N/A      | 0.18 0.25 0.27 | proc-sys-fs-binfmt_misc.mount [failed] |       |
|              |        |     |           |          |                | everyaws.service [failed]              |       |
| kif          | Yes    | Yes | Yes       | N/A      | 0.11 0.22 0.26 | proc-sys-fs-binfmt_misc.mount [failed] |       |
| lord-nibbler | Yes    | Yes | Yes       | N/A      | 0.00 0.05 0.01 | proc-sys-fs-binfmt_misc.mount [failed] |       |
| ogden        | Yes    | No  | N/A       | N/A      |                |                                        |       |
+--------------+--------+-----+-----------+----------+----------------+----------------------------------------+-------+
Non machines resources state:
+------+--------+
| Name | Exists |
+------+--------+
+------+--------+
@grahamc
Copy link
Member

grahamc commented May 1, 2020

I won't block on the ratchet, but if anyone wants to add a commit improving type coverage in this file that would be cool :).

@grahamc grahamc merged commit 304a1d3 into NixOS:master May 1, 2020
5 of 6 checks passed
5 of 6 checks passed
parsing
Details
build
Details
black
Details
mypy
Details
mypy-ratchet mypy-ratchet
Details
coverage
Details
@manveru
Copy link
Contributor Author

manveru commented May 1, 2020

@grahamc what is this ratchet thing, and why does it not like the commit?

@adisbladis
Copy link
Member

adisbladis commented May 1, 2020

@manveru It's to force us to increase type coverage over time, so we measure the coverage before and after the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.