Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Plugin types: Tie a ResourceState to its corresponding ResourceDefinition #1346
Explicitly subclassed Protocols don't support super().__init__ ... but we need that. See: python/typing#572 for a description, including the below workaround. Protocol doesn't give us any special run-time behavior (except for runtime_checkable,) and can be pretty transparently swapped out for Generic at run time. By using Generic at run-time, we get the expected __init__ behavior. But, we still want Protocols at type-checking time because Protocol is much stricter about assigning to `self` without explicitly defining and typing the object variable. In conclusion, I'm sorry. Hopefully python/typing#572 gets fixed and we can delete this and go back to the isinstance check in deployment.py. Co-authored-by: Graham Christensen <email@example.com>
grahamc merged commit
May 18, 2020
10 checks passed
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.