Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deployment.py: fixup mistakes in #1346 #1348

Merged
merged 2 commits into from May 19, 2020
Merged

Conversation

@grahamc
Copy link
Member

grahamc commented May 18, 2020

No description provided.

@tewfik-ghariani
Copy link
Contributor

tewfik-ghariani commented May 18, 2020

Can we use

if dep._destroyed_event:

instead of

if dep._destroyed_event is not None:

As far as I remember, it improves slightly the performance and surely it's easier to read

@grahamc
Copy link
Member Author

grahamc commented May 19, 2020

I think that is probably fine, what do you think @adisbladis?

@adisbladis
Copy link
Member

adisbladis commented May 19, 2020

@grahamc Fine by me, since it's Optional[Event] it's always truthy when set.

@adisbladis adisbladis merged commit a12351e into NixOS:master May 19, 2020
10 checks passed
10 checks passed
parsing
Details
build
Details
black
Details
mypy
Details
flake8
Details
mypy-ratchet
Details
coverage
Details
docs
Details
poetry-up-to-date
Details
docs/readthedocs.org:nixops Read the Docs build succeeded!
Details
@grahamc
Copy link
Member Author

grahamc commented May 19, 2020

Thanks, @tewfik-ghariani and @adisbladis!

@grahamc grahamc deleted the grahamc:fixup-1346 branch May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.