Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{default,shell}.nix: don't use builtins.fetchGit #1371

Merged
merged 2 commits into from Jun 23, 2020

Conversation

@cole-h
Copy link
Member

cole-h commented Jun 13, 2020

Otherwise, this would prevent one from using import (fetchTarball "https://github.com/NixOS/nixops/archive/master.tar.gz") to run NixOps
from the master branch, for example. If you try to do so, you would see
some output like the following:

fatal: '/nix/store/nysvzmqi11zfchympbksb8wcb2dxw6yz-source' does not appear to be a git repository
fatal: Could not read from remote repository.

Fixes #1370.

cole-h added 2 commits Jun 13, 2020
Otherwise, this would prevent one from using `import (fetchTarball
"https://github.com/NixOS/nixops/archive/master.tar.gz")` to run NixOps
from the master branch, for example. If you try to do so, you would see
some output like the following:

    fatal: '/nix/store/nysvzmqi11zfchympbksb8wcb2dxw6yz-source' does not appear to be a git repository
    fatal: Could not read from remote repository.
@cole-h cole-h force-pushed the cole-h:dont-use-fetchGit branch from 36c7e57 to bf8508b Jun 17, 2020
@cole-h cole-h changed the title default.nix: don't use builtins.fetchGit {default,shell}.nix: don't use builtins.fetchGit Jun 17, 2020
@cole-h
Copy link
Member Author

cole-h commented Jun 17, 2020

This bumps flake-compat to include edolstra/flake-compat#4 (as well as support for versions 6 and 7 of the lockfile) -- now, builtins.fetchGit will be used automatically in the case that .git is present.

@nlewo
nlewo approved these changes Jun 17, 2020
Copy link
Member

nlewo left a comment

@adisbladis I will push a PR on top of this one to update the pipeline, since we can now use a shallow repository.

@adisbladis adisbladis merged commit b743ad9 into NixOS:master Jun 23, 2020
10 checks passed
10 checks passed
parsing
Details
build
Details
black
Details
mypy
Details
flake8
Details
mypy-ratchet
Details
coverage
Details
docs
Details
poetry-up-to-date
Details
docs/readthedocs.org:nixops Read the Docs build succeeded!
Details
@cole-h cole-h deleted the cole-h:dont-use-fetchGit branch Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.