Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add dynect aRecord support #327

Closed
wants to merge 1 commit into from

Conversation

@thedebugger
Copy link

@thedebugger thedebugger commented Aug 7, 2015

No description provided.

@thedebugger
Copy link
Author

@thedebugger thedebugger commented Aug 7, 2015

FYI, Unit tests coming..

@thedebugger thedebugger force-pushed the thedebugger:add_dyn_support branch from a0339c8 to 4345cc5 Aug 7, 2015
{
options = {
name = mkOption {
default = "charon-${uuid}-${name}";

This comment has been minimized.

@edolstra

edolstra Aug 7, 2015
Member

Please change charon to nixops. (There are a few places where we use charon for backward compatibility, but obviously that's not needed for new resource types.)

@thedebugger thedebugger force-pushed the thedebugger:add_dyn_support branch from 4345cc5 to c9de328 Aug 10, 2015
@rbvermaa
Copy link
Member

@rbvermaa rbvermaa commented Sep 9, 2015

Did you already manage to put dyn into nixpkgs, and add a test?

@thedebugger
Copy link
Author

@thedebugger thedebugger commented Sep 15, 2015

I didn't get time to add tests, but will do that soon. I did add dyn in nixpkgs but have to figure out why my PR is failing. Here is the PR: NixOS/nixpkgs#9380

@domenkozar
Copy link
Member

@domenkozar domenkozar commented Feb 10, 2016

Dyn is now in nixpkgs.

@domenkozar domenkozar added the feature label Feb 10, 2016
@domenkozar domenkozar changed the title Add dynect aRecord support [WIP] Add dynect aRecord support Mar 27, 2017
@domenkozar
Copy link
Member

@domenkozar domenkozar commented Mar 27, 2017

This needs cleaning up.

@grahamc
Copy link
Member

@grahamc grahamc commented Mar 26, 2020

Hello!

Thank you for this PR.

In the past several months, some major changes have taken place in
NixOps:

  1. Backends have been removed, preferring a plugin-based architecture.
    Here are some of them:

  2. NixOps Core has been updated to be Python 3 only, and at the
    same time, MyPy type hints have been added and are now strictly
    required during CI.

This is all accumulating in to what I hope will be a NixOps 2.0
release
. There is a tracking issue for that:
#1242 . It is possible that
more core changes will be made to NixOps for this release, with a
focus on simplifying NixOps core and making it easier to use and work
on.

My hope is that by adding types and more thorough automated testing,
it will be easier for contributors to make improvements, and for
contributions like this one to merge in the future.

However, because of the major changes, it has become likely that this
PR cannot merge right now as it is. The backlog of now-unmergable PRs
makes it hard to see which ones are being kept up to date.

If you would like to see this merge, please bring it up to date with
master and reopen it
. If the or mypy type checking fails, please
correct any issues and then reopen it. I will be looking primarily at
open PRs whose tests are all green.

Thank you again for the work you've done here, I am sorry to be
closing it now.

Graham

@grahamc grahamc closed this Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.