Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add forwardPorts option to container backend #744

Closed
wants to merge 1 commit into from

Conversation

@ghost
Copy link

@ghost ghost commented Oct 21, 2017

Adds option deployment.container.forwardPorts that forwards ports between nixos-container and host.

Example: [ { protocol = "tcp"; hostPort = 8080; containerPort = 80; } ]

@domenkozar domenkozar requested a review from edolstra Oct 24, 2017
@basvandijk
Copy link
Member

@basvandijk basvandijk commented Nov 21, 2017

@ydlr I was cherry-picking the work that @wavewave did on adding the deployment.container.forwardPorts and deployment.container.hostBridge options (See: master...LumiGuide:container-bridge-port) when I saw your PR.

The most significant change between the two seems to be that you have this section where you optionally overwrite the HOST_PORT setting in /etc/containers/{1}.conf. I guess this is needed so that when you change forwardPorts the change is reflected in the existing container configuration. Since that code is not in my branch I would prefer your PR.

My branch does add the deployment.container.hostBridge option which I would like to have in nixops. I will make a separate PR that adds that option when this PR gets merged.

@domenkozar what do you think about this PR?

@wavewave
Copy link

@wavewave wavewave commented Nov 25, 2017

@basvandijk Thank you so much for proceeding this! I couldn't find the time to turn this to PR recently. I am very glad to see this happens 👍

@grahamc
Copy link
Member

@grahamc grahamc commented Mar 26, 2020

Hello!

Thank you for this PR.

In the past several months, some major changes have taken place in
NixOps:

  1. Backends have been removed, preferring a plugin-based architecture.
    Here are some of them:

  2. NixOps Core has been updated to be Python 3 only, and at the
    same time, MyPy type hints have been added and are now strictly
    required during CI.

This is all accumulating in to what I hope will be a NixOps 2.0
release
. There is a tracking issue for that:
#1242 . It is possible that
more core changes will be made to NixOps for this release, with a
focus on simplifying NixOps core and making it easier to use and work
on.

My hope is that by adding types and more thorough automated testing,
it will be easier for contributors to make improvements, and for
contributions like this one to merge in the future.

However, because of the major changes, it has become likely that this
PR cannot merge right now as it is. The backlog of now-unmergable PRs
makes it hard to see which ones are being kept up to date.

If you would like to see this merge, please bring it up to date with
master and reopen it
. If the or mypy type checking fails, please
correct any issues and then reopen it. I will be looking primarily at
open PRs whose tests are all green.

Thank you again for the work you've done here, I am sorry to be
closing it now.

Graham

@grahamc grahamc closed this Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.