Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Hard coding such constants seems to be a flawed approach requiring a ton of maintenance(they change scheme every few years). I have little doubt that there is a way to do these things dynamically and in a way that is only kernel dependent (e.g. Linux or FreeBSD) and not on a particular version.
Perhaps it could be done in a platform independent way by using some cross-platform tools.
Another thing I don't really like is that a PR is opened in which the word "breaks" occurs. OTOH, perhaps we should be happy that the disassembler took the time to improve something to the DigitalOcean user community. I suppose what it comes down to is whether it would constitute a net "improvement" (which is why it isn't merged yet). If breaking something means we don't merge it, we should just be honest about that and thank disassembler for the attempt and close the PR. I don't know what the correct response is, but having 5 people (including me) look at it, seems to be a waste of resources. One qualified reviewer is economically optimal according to research. While no money changes hands, there are such limits as time and attention.
I vote to close this PR, just to draw a line.
Thank you for this PR.
In the past several months, some major changes have taken place in
This is all accumulating in to what I hope will be a NixOps 2.0
My hope is that by adding types and more thorough automated testing,
However, because of the major changes, it has become likely that this
If you would like to see this merge, please bring it up to date with
Thank you again for the work you've done here, I am sorry to be