Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Don't use port open check to determine if reboot completed. Fixes #856. #857
The old approach, waiting for the machine to not having an open
The new approach checks the
Changed output with this patch:
Alternative output that can be created by this:
So the output is not as pretty as before due to the errors, but at least it works without race-condition.
The old approach, waiting for the machine to not having an open port, and then waiting for it to be open again, was insufficient, because of the race condition that the machine rebooted so quickly that the port was immediately open again without nixops noticing that it went down. I experienced this on a Hetzner cloud server. The new approach checks the `last reboot` on the remote side to change, which is not racy.
Thank you for this PR.
In the past several months, some major changes have taken place in
This is all accumulating in to what I hope will be a NixOps 2.0
My hope is that by adding types and more thorough automated testing,
However, because of the major changes, it has become likely that this
If you would like to see this merge, please bring it up to date with
Thank you again for the work you've done here, I am sorry to be