Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
Add initial support for hetzner cloud #944
It's working, almost done and the only thing missing is a NixOS-infect style thing.
A difference I can see between our approaches from skimming the PR for 1 minute is that you use the REST API directly while I use a Python package that does it.
@goodraven Are you in a hurry getting this merged? Otherwise I recommend we take some time to read each other's PRs in detail and then unify them.
aszlig left a comment
Thanks for the implementation. Apart from the commented points, running
This pull request has been mentioned on Nix community. There might be relevant details there:
Thank you for this PR.
In the past several months, some major changes have taken place in
This is all accumulating in to what I hope will be a NixOps 2.0
My hope is that by adding types and more thorough automated testing,
However, because of the major changes, it has become likely that this
If you would like to see this merge, please bring it up to date with
Thank you again for the work you've done here, I am sorry to be