Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
DO NOT MERGE: Nix 2 out of memory workaround #972
This is a workaround for the
It includes my fix from NixOS/nix#2206
How to use this workaround
Use this branch and set
for your AWS machines.
That will ensure the machine gets initially deployed with 17.09 which doesn't have the memory problem, will then get nix 2 with my patch deployed, so that in no of the two states is the problem present.
This is probably not intended to be merged, at least not with the hard nix override in the second patch.
However, if we made that override an option, then we could merge this.
Right now this is just to present a publicly visible workaround for people to use, until there's an official
I was just testing t2.nano/t2.micro instances with
@nh2 I'm going to close this PR as it seems that it's probably not relevant anymore, please feel free to re-open if you think I missed anything. Thanks
@AmineChikhaoui I'd still like to merge the
Even though Nix 2.1 fixes the memory issue, I don't think it will help if based on the 18.03 AMI.
Because when you deploy the first time from the 18.03, the
Looks like I can't do that, I can only comment.
I don't think
However, I think
and yeah most likely the issue will persist unless Nix is built and activated before copying the closure which doesn't happen.
I don't understand this argument. The idea here is that
The initial boot from AMI will bring up a version of nix that is so old that it doesn't have the problem. The first deployment will then instal whatever version of nix that I specify, which of course would have the patches in to fix the issue.
At no point would a 2.0 version without the issue patched be installed on the target system.
Thank you for this PR.
In the past several months, some major changes have taken place in
This is all accumulating in to what I hope will be a NixOps 2.0
My hope is that by adding types and more thorough automated testing,
However, because of the major changes, it has become likely that this
If you would like to see this merge, please bring it up to date with
Thank you again for the work you've done here, I am sorry to be