Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
deployment.py: handle checking DiffStateEngineResourceState #980
Doing some ... weird ... stuff .. I found:
which can cause the comparisons to happen in the wrong order, resulting in
File /nix/store/iym5qcmlwbxi7f66mh7bsv4jfnybhgrs-python2.7-nixops-1.6.1pre0_abcdef/lib/python2.7/site-packages/nixops/resources/init.py, line 40, in get_type
This handles that and allows continued comparisons.
subclasses returns: [<class 'nixops.resources.DiffEngineResourceState'>, <class 'nixops.backends.none.NoneState'>, <class 'nixops.resources.ssh_keypair.SSHKeyPairState'>] which can cause the comparisons to happen in the wrong order, resulting in File /nix/store/iym5qcmlwbxi7f66mh7bsv4jfnybhgrs-python2.7-nixops-1.6.1pre0_abcdef/lib/python2.7/site-packages/nixops/resources/__init__.py, line 40, in get_type raise NotImplementedError(get_type) NotImplementedError: get_type oops
Yeah, but it is a bit weird (hence "stuff" ;) If you check out my commit here in a network where your only resource type are machines with the targetEnv of
Thank you for this PR.
In the past several months, some major changes have taken place in
This is all accumulating in to what I hope will be a NixOps 2.0
My hope is that by adding types and more thorough automated testing,
However, because of the major changes, it has become likely that this
If you would like to see this merge, please bring it up to date with
Thank you again for the work you've done here, I am sorry to be