Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mirror-nixos-branch.pl: exit 0 if the channel would go back in time #28

Merged
merged 1 commit into from Nov 15, 2019

Conversation

@grahamc
Copy link
Member

@grahamc grahamc commented Nov 15, 2019

Prometheus now has a configured alert if an update job fails for a
while. Going back in time is not so unusual:

  1. a hydra evaluation completes with some failed jobs
  2. the channel advances to this commit
  3. an admin restarts a failed job
  4. the channel would go backward because the evaluation is complete

Since it is not a problem, make it a non-problematic exit code.

Prometheus now has a configured alert if an update job fails for a
while. Going back in time is not so unusual:

1. a hydra evaluation completes with some failed jobs
2. the channel advances to this commit
3. an admin restarts a failed job
4. the channel would go backward because the evaluation is complete

Since it is not a problem, make it a non-problematic exit code.
@edolstra edolstra merged commit 0df25e1 into master Nov 15, 2019
@edolstra edolstra deleted the back-in-time-exit-code branch Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.