Fix SVG embedding + prepare for development #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The viewbox caused the wedge to not render as expected when directly embedded in the CSS.
This adds a less function that *directly* transcludes the content of a file as a string. In turn, this will be used to replace the clumsy SVG embedding during the build process.
In addition, using `"g"` in `replace()` fixes a *well-hidden* set of bugs where it was possible to miss replacements and actually have broken results.
Since we're not embedding clumsily anymore, we're not optimizing those files eagerly anymore. This shouldn't be an issue, as consumers *should* optimize SVG files, but in the off chance they don't, let's optimize them eagerly again.
|
The CI build seems to be broken... |
samueldr
added a commit
to NixOS/nixos-homepage
that referenced
this pull request
Jan 17, 2022
This was referenced Jan 17, 2022
Merged
samueldr
commented
Jan 19, 2022
Comment on lines
+7
to
+11
| let filename = filenameNode.value; | ||
| const {currentDirectory} = this.currentFileInfo; | ||
| const fullFilename = path.join(currentDirectory, filename); | ||
|
|
||
| return readFileSync(fullFilename); |
There was a problem hiding this comment.
Formatting to be reviewed
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2022-01-19-marketing-meeting-minutes/17209/1 |
garbas
approved these changes
Jan 21, 2022
|
I've tested the build locally and I'll fix the github workflow in a separate PR |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2022-02-02-marketing-meeting-minutes/17542/1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses a
lessplugin to read SVG files rather than clumsily embedding them with a script.This speeds up the dev cycle a lot.
The main unsolved issue, and would be solved in the actual consumer, is how to optimize the SVG assets in development use. For production use it's already solved.
See: