Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Dell XPS 15 9560 #139

Merged
merged 2 commits into from Feb 18, 2020
Merged

Adding Dell XPS 15 9560 #139

merged 2 commits into from Feb 18, 2020

Conversation

@danielstaleiny
Copy link
Contributor

@danielstaleiny danielstaleiny commented Feb 5, 2020

Add xps 9560 with its own quirks, I added versions:

1 default one, with nvidia working and intel working, needs optirun to
run application with nvidia
2 intel only, I am using this as my daily driver for long time, only
intel is turned on and nvidia is turned off and doesn't drain any
power.
3 nvidia only, intel is dissabled and nvidia is picked as default gpu,
no need to fiddle with optirun etc, good for gpu heavy application.

All these settings needs to reboot to work properly.

@Mic92
Copy link
Contributor

@Mic92 Mic92 commented Feb 12, 2020

Anything left to do here?

@danielstaleiny
Copy link
Contributor Author

@danielstaleiny danielstaleiny commented Feb 12, 2020

I need to test it and make it ready for review. :))

@Mic92
Copy link
Contributor

@Mic92 Mic92 commented Feb 18, 2020

Did you had the chance to test it?

1 default one, with nvidia working and intel working, needs optirun to
run application with nvidia
2 intel only, I am using this as my daily driver for long time, only
intel is turned on and nvidia is turned off and doesn't drain any
power.
3 nvidia only, intel is dissabled and nvidia is picked as default gpu,
no need to fiddle with optirun etc, good for gpu heavy application.

All these settings needs to reboot to work properly
@danielstaleiny danielstaleiny marked this pull request as ready for review Feb 18, 2020
@danielstaleiny
Copy link
Contributor Author

@danielstaleiny danielstaleiny commented Feb 18, 2020

I tested the default, nvidia and intel configuration and on my laptop everything works as intended. You can merge. :))

@danielstaleiny
Copy link
Contributor Author

@danielstaleiny danielstaleiny commented Feb 18, 2020

Could you restart the checks, because it run out of memory that is not related to my pull request. or am I wrong ?

@Mic92
Copy link
Contributor

@Mic92 Mic92 commented Feb 18, 2020

Yes. The travis failure is unrelated to your change. I will ignore it for the time being.

@Mic92 Mic92 merged commit 5904e76 into NixOS:master Feb 18, 2020
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@moritzschaefer

This comment has been minimized.

Copy link

@moritzschaefer moritzschaefer commented on 8b50556 May 3, 2020

Great work @danielstaleiny. Is there a paricular reason why no power management method is chosen for nvidia? (https://github.com/Bumblebee-Project/Bumblebee/wiki/Comparison-of-PM-methods)

And: On the NVIDIA page it is recommended to use PRIME instead of Bumblebee. Is there a reason, you used bumblebee here or is PRIME just a very recent recommendation?

This comment has been minimized.

Copy link
Contributor Author

@danielstaleiny danielstaleiny replied May 3, 2020

What do you mean by no power management ? I am not that experienced with bumblebee & PRIME but I do understand the practical difference.

My use case was that by having nvidia only, I don't have to prefix games to run under nvidia, but it drains power like crazy.
Normally I use intel only, and battery life is great.
The reason why I made nvidia only is that I want to disable intel one. I don't know any other way to do it.

If you have suggestions let me know.

This comment has been minimized.

Copy link

@moritzschaefer moritzschaefer replied May 3, 2020

It sounds like a really convenient system to just switch like this from intel to nvidia. Unfortunately, /dell/xps/15-9560/intel freezes my xserver immediately after start.
I just tried using PRIME offload as described here (https://nixos.wiki/wiki/Nvidia#Nvidia_PRIME) and it does reduce my power consumption to 19 Watts (10 Watts with screen off).
I'll see if this is stable and would eventually do a PR

This comment has been minimized.

Copy link
Contributor Author

@danielstaleiny danielstaleiny replied May 3, 2020

Yes, From time to time I experience x freeze, but you can do sudo nixos-rebuild switch && reboot and you are okey. When you reboot, everything works and there I haven't experienced any freezing. Also if you are testing run sudo nixos-rebuild vm , to speed up process of trying. :))

So from my experience it is stable while running, and sometimes iffy if you are switching. I have regular screen. If you do PR ping me and I will test it as well :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.