Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a shared HiDPI Configuration, use it. #157

Open
wants to merge 3 commits into
base: master
from

Conversation

@pmyjavec
Copy link

pmyjavec commented May 3, 2020

I've noticed other laptops with HiDPI displays have this configuration set and my laptop didn't, so I thought it might be worth adding a common configuration for basic HiDPI display settings which seem quite universal.

@Mic92
Copy link
Contributor

Mic92 commented May 3, 2020

Agreed!

common/pc/display/hidpi.nix Outdated Show resolved Hide resolved
@wmertens
Copy link
Contributor

wmertens commented May 5, 2020

How does this behave when you plug in a FHD display? Xrandr/Wayland will do the right thing?

@utdemir
Copy link
Member

utdemir commented May 12, 2020

Sorry, this is a bit off topic, but is there a way to check if the display I have is HiDPI? If there is, it might be worth putting it as a comment somewhere.

pmyjavec added 3 commits May 3, 2020
Use the common HiDPI configuration with the X1 Extreme, without this X
and fonts looked jacked up.
Ensure the change covers all bases, including making the terminal look
good on HiDPI displays.
@pmyjavec pmyjavec force-pushed the pmyjavec:master branch from 4447696 to 16d6316 May 12, 2020
@pmyjavec pmyjavec closed this May 12, 2020
@pmyjavec pmyjavec reopened this May 12, 2020
@pmyjavec
Copy link
Author

pmyjavec commented May 12, 2020

Sorry, this is a bit off topic, but is there a way to check if the display I have is HiDPI? If there is, it might be worth putting it as a comment somewhere.

How does this behave when you plug in a FHD display? Xrandr/Wayland will do the right thing?

@wmertens , sorry I don't use wayland!

@Mic92
Copy link
Contributor

Mic92 commented May 12, 2020

cc @colemickens Can you have a look regarding wayland. I also only tested them on Xorg.

@Mic92
Copy link
Contributor

Mic92 commented May 12, 2020

I wonder if we should move this module to nixpkgs? We could include it in nixos-generators if we detect a large screen on installation. This way also desktops are covered.

@pmyjavec
Copy link
Author

pmyjavec commented May 13, 2020

@Mic92 I think that would greatly improve the user experience when first using NixOS! Especially as Retina/HiDPI screens are becoming more prominent.

@matthewbauer
Copy link
Member

matthewbauer commented May 13, 2020

I wonder if we should move this module to nixpkgs? We could include it in nixos-generators if we detect a large screen on installation. This way also desktops are covered.

HiDPI isn’t really a property of the machine, but the display. I think it’s probably okay to put it in hardware-configuration.nix for laptops which have a fixed display but Xorg and fontconfig should be able to detect the DPI at runtime.

@Mic92
Copy link
Contributor

Mic92 commented May 13, 2020

I wonder if we should move this module to nixpkgs? We could include it in nixos-generators if we detect a large screen on installation. This way also desktops are covered.

HiDPI isn’t really a property of the machine, but the display. I think it’s probably okay to put it in hardware-configuration.nix for laptops which have a fixed display but Xorg and fontconfig should be able to detect the DPI at runtime.

They don't adjust at runtime and I don't know why. @lheckemann has added hidpi detection to our configuration generator: https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/installer/tools/nixos-generate-config.pl#L501

Even if we don't enable it by default I still see some value if it would be just one import away in NixOS.

@Mic92
Copy link
Contributor

Mic92 commented May 13, 2020

I opened a pull request: NixOS/nixpkgs#87730

@Mic92 Mic92 mentioned this pull request May 13, 2020
4 of 10 tasks complete
@pmyjavec
Copy link
Author

pmyjavec commented May 21, 2020

Did we still want this change? Is it just awaiting further testing?

@Mic92
Copy link
Contributor

Mic92 commented May 23, 2020

I made a new PR here: NixOS/nixpkgs#88669 to include at least the console stuff in a nixos module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.