Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dell/xps/13-9360: Stop using i18n.consoleFont #163

Merged
merged 1 commit into from May 15, 2020
Merged

Conversation

@00-matt
Copy link
Contributor

00-matt commented May 14, 2020

Fixes deprecation warning:

trace: warning: The option i18n.consoleFont defined in /nix/var/nix/profiles/per-user/root/channels/nixos-hardware/dell/xps/13-9360 has been renamed to `console.font'.

Copy link

rnhmjoj left a comment

It may be useful to keep compatibility with the old name for a while, see here:

(if lib.versionAtLeast (lib.versions.majorMinor lib.version) "20.03" then {

trace: warning: The option `i18n.consoleFont' defined in
`/nix/var/nix/profiles/per-user/root/channels/nixos-hardware/dell/xps/13-9360'
has been renamed to `console.font'.
@00-matt
Copy link
Contributor Author

00-matt commented May 14, 2020

@wmertens
Copy link
Contributor

wmertens commented May 14, 2020

Lgtm

@Mic92
Copy link
Contributor

Mic92 commented May 15, 2020

I cannot reproduce the CI failure but it is unrelated to this PR.

@Mic92 Mic92 merged commit a36f343 into NixOS:master May 15, 2020
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
@00-matt
Copy link
Contributor Author

00-matt commented May 15, 2020

@00-matt 00-matt deleted the 00-matt:dell-xps-13-9360/consolefont branch May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.