Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pc/laptop: remove redundant cpuFreqGovernor setting #169

Merged
merged 1 commit into from May 20, 2020

Conversation

@erikarvstedt
Copy link
Member

erikarvstedt commented May 20, 2020

This setting has been part of NixOS since version 16.09.

It's defined in services/hardware/tlp.nix.

This setting has been part of NixOS since version 16.09
@Mic92 Mic92 merged commit 2f2c2d9 into NixOS:master May 20, 2020
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@wmertens
Copy link
Contributor

wmertens commented May 20, 2020

I don't see it in that file, only setting it to null?

@erikarvstedt
Copy link
Member Author

erikarvstedt commented May 20, 2020

Yes, cpuFreqGovernor is set to null when tlp is enabled. We previously did that in laptop/default.nix, but it's already handled by tlp.nix.

@erikarvstedt erikarvstedt deleted the erikarvstedt:improve-laptop-preset branch May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.