Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Lenovo Thinkpad E470 #192

Merged
merged 5 commits into from Oct 12, 2020
Merged

Adding Lenovo Thinkpad E470 #192

merged 5 commits into from Oct 12, 2020

Conversation

@hoppla20
Copy link
Contributor

@hoppla20 hoppla20 commented Sep 23, 2020

No description provided.

README.md Show resolved Hide resolved
@hoppla20
Copy link
Contributor Author

@hoppla20 hoppla20 commented Sep 27, 2020

I also added a note in the README to also link the file in flake.nix

nvidiaBusId = lib.mkDefault "PCI:1:0:0";
};

boot.kernelPackages = pkgs.linuxPackages_latest;
Copy link
Member

@Mic92 Mic92 Sep 28, 2020

Is there a minimum kernel version that we need? At some point it would be nice to unpin this line. Please leave a comment which kernel version you need as lower bound.

Copy link
Member

@Mic92 Mic92 Sep 28, 2020

Maybe something like this helps:

boot.kernelPackages = lib.mkIf (lib.versionOlder pkgs.linux.version "5.6") pkgs.linuxPackages_latest;

Copy link
Contributor Author

@hoppla20 hoppla20 Oct 1, 2020

Changed 😁

@hoppla20
Copy link
Contributor Author

@hoppla20 hoppla20 commented Oct 7, 2020

Could this be merged? 😅

@Mic92 Mic92 merged commit 55acbf7 into NixOS:master Oct 12, 2020
1 check passed
@Mic92
Copy link
Member

@Mic92 Mic92 commented Oct 12, 2020

Thanks for the chase up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants