Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the Lenovo Thinkpad L14 (AMD) laptop #194

Merged
merged 1 commit into from Oct 15, 2020
Merged

Conversation

@blitz
Copy link
Contributor

@blitz blitz commented Oct 7, 2020

This PR adds support for the Lenovo Thinkpad L14 Gen 1 laptop with AMD Ryzen CPU (Renoir).

I'm not 100% sure where to put the module. If some one has a better idea than l14-amd I'm all ears. Should it be l14/amd instead?

@blitz blitz changed the title Add support for the Lenovo L14 (AMD) laptop Add support for the Lenovo Thinkpad L14 (AMD) laptop Oct 7, 2020
flake.nix Outdated Show resolved Hide resolved
{
imports = [
../.
../../../common/cpu/amd

This comment has been minimized.

@Mic92

Mic92 Oct 12, 2020
Contributor

Could their be a generic l14 module that gets extended by the more specific amd profile?

This comment has been minimized.

@blitz

blitz Oct 14, 2020
Author Contributor

So I've created l14/amd and l14/intel. I've populated the l14/intel profile with the same content as the l13 profile, because its basically the same laptop in a smaller chassis, but I couldn't test it.

Add support for the Lenovo Thinkpad L14 Gen 1 Intel and AMD variants.
@blitz blitz force-pushed the blitz:l14-amd branch from b3a8f8f to ccf7985 Oct 14, 2020
@blitz blitz requested a review from Mic92 Oct 14, 2020
@Mic92 Mic92 merged commit b382727 into NixOS:master Oct 15, 2020
1 check passed
1 check passed
tests tests
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.