Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raspberry-pi-4: add poe-plus-hat, update poe-hat, use dtmerge instead of fdtoverlay #442

Merged
merged 6 commits into from
Aug 9, 2022

Conversation

carlossless
Copy link
Contributor

@carlossless carlossless commented Aug 7, 2022

Changes here:

  • update the poe-hat-overlay dts to work with the 5.15y release of rpis kernel
  • add poe-plus-hat-overlay for use with the PoE+ HAT
  • using dtmerge from libraspberypi instead of fdtoverlay for the added overlays that require it's the usage

This should provide a ready-to-use solution for:

There's likely many ways these expressions could be made better, so feedback is very much appreciated.

@carlossless carlossless changed the title raspberry-pi-4: add poe-plus-hat, update poe-hat, use dtmerge instead of ftoverlay raspberry-pi-4: add poe-plus-hat, update poe-hat, use dtmerge instead of fdtoverlay Aug 7, 2022
@carlossless carlossless marked this pull request as ready for review August 7, 2022 11:11
@carlossless carlossless force-pushed the raspberry-pi-4-poe-hats branch from 581a333 to 128dad1 Compare August 7, 2022 11:40
Copy link
Member

@06kellyjac 06kellyjac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally good, just some thoughts although the nativeBuildInputs change is strongly recommended :)

raspberry-pi/4/apply-overlays-dtmerge.nix Outdated Show resolved Hide resolved
raspberry-pi/4/apply-overlays-dtmerge.nix Outdated Show resolved Hide resolved
raspberry-pi/4/apply-overlays-dtmerge.nix Show resolved Hide resolved
raspberry-pi/4/pkgs-overlays.nix Outdated Show resolved Hide resolved
raspberry-pi/4/pkgs-overlays.nix Outdated Show resolved Hide resolved
raspberry-pi/4/apply-overlays-dtmerge.nix Outdated Show resolved Hide resolved
raspberry-pi/4/pkgs-overlays.nix Show resolved Hide resolved
@carlossless
Copy link
Contributor Author

@06kellyjac thanks for the review and all the suggestions, not sure how but my first change batch somehow missed them, but everything should be changed now.

@Mic92 Mic92 merged commit f064a4e into NixOS:master Aug 9, 2022
@carlossless carlossless deleted the raspberry-pi-4-poe-hats branch September 11, 2022 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants