-
-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
raspberry-pi-4: add poe-plus-hat, update poe-hat, use dtmerge instead of fdtoverlay #442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlossless
changed the title
raspberry-pi-4: add poe-plus-hat, update poe-hat, use dtmerge instead of ftoverlay
raspberry-pi-4: add poe-plus-hat, update poe-hat, use dtmerge instead of fdtoverlay
Aug 7, 2022
carlossless
force-pushed
the
raspberry-pi-4-poe-hats
branch
from
August 7, 2022 11:40
581a333
to
128dad1
Compare
06kellyjac
reviewed
Aug 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally good, just some thoughts although the nativeBuildInputs
change is strongly recommended :)
Co-authored-by: j-k <dev@j-k.io>
06kellyjac
reviewed
Aug 8, 2022
06kellyjac
reviewed
Aug 8, 2022
@06kellyjac thanks for the review and all the suggestions, not sure how but my first change batch somehow missed them, but everything should be changed now. |
06kellyjac
approved these changes
Aug 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes here:
dtmerge
fromlibraspberypi
instead offdtoverlay
for the added overlays that require it's the usageThis should provide a ready-to-use solution for:
There's likely many ways these expressions could be made better, so feedback is very much appreciated.