Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apple: Add support for MacBook Air 3,X #91

Merged
merged 5 commits into from Nov 12, 2019
Merged

apple: Add support for MacBook Air 3,X #91

merged 5 commits into from Nov 12, 2019

Conversation

@ilian
Copy link
Member

@ilian ilian commented Dec 31, 2018

Add support for MacBook Air 3,X, which only contains a NVIDIA GeForce 320M GPU instead of integrated Intel graphics.
The configuration contains the black screen fix for this model.

apple/macbook-air/3/default.nix Outdated Show resolved Hide resolved
apple/macbook-air/3/default.nix Outdated Show resolved Hide resolved
This removes GRUB as a dependency.
@ilian
Copy link
Member Author

@ilian ilian commented Feb 5, 2019

Hi, thanks for reviewing!
I've tested the current state of the video driver support of this model:
Starting display-manager from the install ISO results in X Server not finding a screen and thus requires installation from the tty.
After installation, nouveau seems to be working fine out of the box and does not require setpci tweaking. KDE desktop effects and video playback at 1080p@60fps of an H.264 sample file are both working without requiring the installation of the proprietary Nvidia driver.
Installing the legacy Nvidia driver causes a kernel panic as soon as the X server starts even though it worked fine about 6 months ago.

[  61.431767] BUG: unable to handle kernel NULL pointer dereference at 0000000000000328
[  61.431950] IP: _nv006854rm+0x272/0x3c0 [nvidia]

I'm closing this PR because nouveau is working well and seems stable, while the proprietary driver is breaking.

@ilian ilian closed this Feb 5, 2019
@Mic92 Mic92 reopened this Feb 6, 2019
@Mic92
Copy link
Member

@Mic92 Mic92 commented Feb 6, 2019

It would still make sense to have this module though.
Having it explicit mentioned also it just imports an upper profile
is a good indication for other people that the module was
tested for this device.

@ilian ilian changed the title apple: Add support for MacBook 3,X apple: Add support for MacBook Air 3,X Nov 7, 2019
hardware.facetimehd.enable = false;

hardware.cpu.intel.updateMicrocode =
lib.mkDefault config.hardware.enableRedistributableFirmware;
Copy link
Member

@Mic92 Mic92 Nov 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not using ../../../common/cpu/intel here?

Copy link
Member

@Mic92 Mic92 Nov 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, just read about the NVIDIA GeForce 320M GPU

@Mic92 Mic92 merged commit adecd11 into NixOS:master Nov 12, 2019
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants