Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dell/xps/13-9380: init #97

Merged
merged 1 commit into from Feb 8, 2019
Merged

Conversation

@kalbasit
Copy link
Member

@kalbasit kalbasit commented Feb 6, 2019

This is pretty much a copy of XPS 9370, without kaby-laky and the throttle bug. I was getting lockups with the kaby-laky changes and the throttle bug did not seem to have an impact either way.

kalbasit added a commit to kalbasit/shabka that referenced this issue Feb 6, 2019
kalbasit added a commit to kalbasit/shabka that referenced this issue Feb 6, 2019
I was getting black screens and random lockups when using the XPS 9370 profile. It turned out to be due to the changes specific to Kaby Lake that are being imported. This CPU is actually Whiskey Lake. The profile also disables a bug fix that is not present on this model.

See NixOS/nixos-hardware#97

fixes #138
kalbasit added a commit to kalbasit/shabka that referenced this issue Feb 6, 2019
I was getting black screens and random lockups when using the XPS 9370 profile. It turned out to be due to the changes specific to Kaby Lake that are being imported. This CPU is actually Whiskey Lake. The profile also disables a bug fix that is not present on this model.

See NixOS/nixos-hardware#97

fixes #138

This reverts commit 6f1d472
@kalbasit kalbasit force-pushed the shabka_fix-xps-13-boot branch from 5b63cf3 to 1adaaa5 Feb 7, 2019
@kalbasit kalbasit requested a review from Infinisil Feb 7, 2019
@@ -0,0 +1,9 @@
= Dell XPS 13 9380 =

== Battery drain when sleeping ==
Copy link
Member

@grahamc grahamc Feb 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're my hero!

@kalbasit kalbasit merged commit 36d8bd8 into NixOS:master Feb 8, 2019
1 check passed
@kalbasit kalbasit deleted the shabka_fix-xps-13-boot branch Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants