Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

download.tt: Mention WSL systemd support #1062

Merged
merged 4 commits into from Jun 4, 2023

Conversation

doronbehar
Copy link
Contributor

No description provided.

Copy link
Contributor

@fricklerhandwerk fricklerhandwerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Small wording suggestion.

Could you please also add this to the Nix manual and nix.dev? It's unfortunate that we have three places for this, but until we decide on one source of truth we unfortunately have to maintain all of them.

download.tt Outdated Show resolved Hide resolved
Co-authored-by: Valentin Gagarin <valentin.gagarin@tweag.io>
@doronbehar
Copy link
Contributor Author

Thanks! Small wording suggestion.

Committed!

Could you please also add this to the Nix manual

Regarding the Nix manual, what page have you had in mind? I was thinking only of:

diff --git i/doc/manual/src/installation/supported-platforms.md w/doc/manual/src/installation/supported-platforms.md
index 8ca3ce8d4..768259a44 100644
--- i/doc/manual/src/installation/supported-platforms.md
+++ w/doc/manual/src/installation/supported-platforms.md
@@ -5,3 +5,5 @@ Nix is currently supported on the following platforms:
   - Linux (i686, x86\_64, aarch64).
 
   - macOS (x86\_64, aarch64).
+
+  - Windows Subsystem for Linux

[...] and nix.dev?

Seems good to me:

https://nix.dev/tutorials/install-nix

It's unfortunate that we have three places for this, but until we decide on one source of truth we unfortunately have to maintain all of them.

Indeed it's unfortunate - I had no idea nix.dev contained that page and I don't see why would we need it.

@fricklerhandwerk
Copy link
Contributor

Regarding the Nix manual, what page have you had in mind?

Looking at all of that after quite some time – ugh, these pages really need some work.

I had no idea nix.dev contained that page and I don't see why would we need it.

nix.dev is now the official documentation resource. I'd rather remove the Nix installation instructions from nixos.org and link the Download button to nix.dev. It would be a first step to reduce the duplication. @NixOS/documentation-team and @NixOS/marketing-team what do you think?

@06kellyjac
Copy link
Member

I know this is about installing nix multi user to generic WSL but is it worth also mentioning NixOS-WSL?
https://github.com/nix-community/NixOS-WSL

I guess it counts as 3rd party so we might be hesitant to do so. nix-community is already referred to but only within the blog section


Also just to clarify it's WSL2 but is versioned as having an 0. Major? (0.67.6)
Or was systemd support in previous WSL releases?

@garbas
Copy link
Member

garbas commented Jun 1, 2023

I'd rather remove the Nix installation instructions from nixos.org and link the Download button to nix.dev. It would be a first step to reduce the duplication. @NixOS/documentation-team and @NixOS/marketing-team what do you think?

I think that would be a step in the wrong direction. Initial onboarding resources should be on main page. What to do when things go wrong (eg. Installation troubleshooting) that would be a place for documentation.

I do understand that from the docs team point of view it makes sense to have the Download page be in the documentation, but from how awkward would it be that download page point to the docs, actually to a completely new domain.

Same goes for initial tutorials, eg. first steps with Nix. First minutes with nix language. That should be part of the main website. And then ... when a user wants to dive deeper, and wants to learn more, direct them to a documentation.

@garbas
Copy link
Member

garbas commented Jun 1, 2023

@doronbehar I'd rever the change back to WSL2 ... https://learn.microsoft.com/en-us/windows/wsl/install#check-which-version-of-wsl-you-are-running

Since Nix only works with WSL2.

@garbas
Copy link
Member

garbas commented Jun 1, 2023

@06kellyjac Can we make it official? Put it in the Windows store/marketplace? Do you want to help out with this?

@fricklerhandwerk
Copy link
Contributor

fricklerhandwerk commented Jun 1, 2023

@garbas we'll fix the broken tutorial links and revert their removal to keep the status quo (that was simply an accident), but we still have to make a call on long-term maintenance.

Multiple sources of truth for installation instructions produced a tangible (albeit not terrible) amount of work in the past months. I'd like to get down to one instance, doesn't matter to me where it lives in principle. The Nix manual is the candidate where it would likely make most sense, as it would be self-contained. @edolstra surely has opinions on that.

The first steps tutorials on nixos.org also require additional maintenance and cognitive overhead, and while we continue developing the presentation on nix.dev, they will keep looking careless and likely break again because some things simply don't translate well, and no one has the time or motivation to take care of that.

Do you have a concrete counter proposal that you can commit to maintain over at least the next half year?

@06kellyjac
Copy link
Member

@06kellyjac Can we make it official? Put it in the Windows store/marketplace? Do you want to help out with this?

Interesting. I don't use Windows or NixOS-WSL so I wouldn't be very helpful here but I'll CC some of the people working on that repo to get their thoughts: @nzbr @K900

@K900
Copy link

K900 commented Jun 1, 2023

We could, but it would require some infra effort to handle signing and such, and the benefits are questionable.

@garbas garbas merged commit 3f332a4 into NixOS:master Jun 4, 2023
2 checks passed
@nzbr
Copy link
Member

nzbr commented Jun 5, 2023

@06kellyjac Can we make it official? Put it in the Windows store/marketplace? Do you want to help out with this?

Interesting. I don't use Windows or NixOS-WSL so I wouldn't be very helpful here but I'll CC some of the people working on that repo to get their thoughts: @nzbr @K900

It'd be nice to get it to the MS Store some day, but for that nix-community/NixOS-WSL/pull/94 needs to be finished, and we'd need to get some sort of official NixOS account on there. We're probably going to aim for being on Scoop and maybe Winget first

@garbas
Copy link
Member

garbas commented Jun 5, 2023

@nzbr Thank you for working on this.

Geting Nix/NixOS to any of the MS Store/Scoop/Winget would mean being available to many new users. I wonder if @NixOS/foundation would be willing to sponsor it, or maybe we open a fundraising like for the documentation team.

Would somebody from the NixOS-WSL contributors be interested to work on this? If needed I (and rest of the @NixOS/marketing-team) can help with fundraising campaign.

@K900
Copy link

K900 commented Jun 5, 2023

The hard part with getting on the Store isn't really funding, it's getting the infra set up to handle signing and such.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants