Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use `nix shell` instead of `nix run` #422

Merged
merged 1 commit into from May 11, 2020

Conversation

@edibopp
Copy link
Contributor

edibopp commented May 11, 2020

This was renamed upstream, see NixOS/nix#3551

For reference, I ran into this here: https://github.com/NixOS/nixos-homepage/pull/418/checks?check_run_id=663327024

This was renamed upstream, see NixOS/nix#3551
@edibopp edibopp mentioned this pull request May 11, 2020
Copy link
Member

davidak left a comment

LGTM

@davidak
Copy link
Member

davidak commented May 11, 2020

We should wait for a new Nix release or even for it to land in NixOS stable? At least add which Nix version is needed for it to work.

How should this dependency hell be handled?

nix-shell -I nixpkgs=https://hydra.nixos.org/build/118764138/download/1/nixos-20.09pre225140.f83c5d3432d.tar.xz -p nix --run "nix shell nixpkgs#gnumake nixpkgs#curl -c make update --keep-going"

😬

@garbas garbas merged commit 3c1792c into NixOS:master May 11, 2020
1 check passed
1 check passed
build-and-deploy
Details
@edolstra
Copy link
Member

edolstra commented May 11, 2020

https://hydra.nixos.org/build/118764138

We shouldn't refer to Hydra because 1) Hydra is not performant enough as a distribution server; and 2) Hydra output could be garbage-collected (they're not at the moment, but they could be).

@edibopp edibopp deleted the edibopp:fix-update-sh branch May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.