Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Landing page (second review cycle) #425

Merged
merged 22 commits into from Jun 3, 2020
Merged

Landing page (second review cycle) #425

merged 22 commits into from Jun 3, 2020

Conversation

@garbas
Copy link
Contributor

garbas commented May 13, 2020

This is a continuation from #387, but I chose to close that PR since the discussion became too long. I hope this would make it easier to review.

I noticed we hit the wall with the discussion there. It is mostly my fault since I opened too many topics at once. I took a step back and simplify what I am trying to do here, while using what we already agree upon.

Here is what I understood we agree uppon:

  • Layout of frontpage ("title + description" with video on the right)
  • Title -> "Reproducible build and deployments"
  • Show examples on landing page

Apart from what we agreed here is what I did:

  • description of Nix and NixOS was giving us problems. I used what we currently have on the website.
  • Along the Download button there is now also "Get started" button which currently points to Learn page but with #418 getting done we should probably point there.
  • point out tree things from current about pages: Reproducible, Declarative, Reliable. The text used there was copied. the only thing I added is that I bolded some parts.
  • added a search box and point out that we have a lot of packages. for nixos options search only a link is provided. Reason for this is that everybody understands what a package is but not many will understand what nixos options are.
  • Packages and Options search in navigation bar was moved to the right and converted into search form. I'm 100% happy with how this is done, but i think it is better then if I would leave Packages/Options items in the navigation bar. I hope to revisit this very soon since work on nixos-search is soon going to be on par with current implementation.
  • Examples are what they are. I think we can do much better, but I would rather merge this and improve on it later.

One of the goals of this PR was to also flatten the navigation and get rid of "per project" navigation. We were already doing this with each page we refreshed, but this rounds up this effort.

Still to be done until we can merge this PR:

  • moving styles from index.tt to css/nixos-site.css
  • merge nix and nixos about page into Features page (currently link in description is broken)
  • review and be 100% that examples work. could we also run this examples on a daily basis, to make sure they always work.
  • video example (will probably we done last)

My main goal is now to merge this as soon as possible with the things that we already agreed upon and open subsequent pull requests to improve. It would be much simpler to have separate discussions on specific parts of the landing page.

Of-course if you think the this PR makes current landing page worse then please comment, I definitely don't want to make things worse.

cc-ing previous reviewers @edolstra @davidak

@garbas garbas requested review from samueldr, davidak and edolstra and removed request for samueldr May 13, 2020
index.tt Show resolved Hide resolved
index.tt Show resolved Hide resolved
index.tt Show resolved Hide resolved
index.tt Show resolved Hide resolved
index.tt Show resolved Hide resolved
index.tt Outdated Show resolved Hide resolved
@garbas garbas mentioned this pull request May 13, 2020
index.tt Outdated Show resolved Hide resolved
index.tt Outdated Show resolved Hide resolved
@nixos-discourse
Copy link

nixos-discourse commented May 21, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/marketing-team-meeting-minutes-5/7303/1

Copy link
Contributor

asymmetric left a comment

Great stuff, a couple of nits :)

index.tt Outdated Show resolved Hide resolved
index.tt Outdated Show resolved Hide resolved
index.tt Show resolved Hide resolved
index.tt Show resolved Hide resolved
garbas and others added 3 commits May 21, 2020
Co-authored-by: davidak <davidak@users.noreply.github.com>
Co-authored-by: asymmetric <lorenzo@mailbox.org>
Co-authored-by: asymmetric <lorenzo@mailbox.org>
@Mic92
Copy link
Contributor

Mic92 commented May 30, 2020

Small typo in the video

- $ # For last example let us build a minimal docker image with Nix
+ $ # For the last example let us build a minimal docker image with Nix                       

However does not really matter.
Great content!

garbas added 2 commits May 30, 2020
@garbas
Copy link
Contributor Author

garbas commented May 30, 2020

@Mic92 Thank you. I fixed the typo.

@garbas
Copy link
Contributor Author

garbas commented May 31, 2020

@danielstaleiny

I would add another section under Multiple languages, one tool

In order to move this PR forward I won't add any examples. But please create a PR against landing-page branch to add an example.

Once this PR gets merged I was hoping to invite the community to brainstorm on examples.

demo.scenario Outdated Show resolved Hide resolved
demo.scenario Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Jun 1, 2020

@davidak
Copy link
Member

davidak commented Jun 1, 2020

it's too fast!!! i can't read that fast. it's already gone when i have read half of the sentences.

give people some time to read and understand

virtualHosts."example.com" = {
enableACME = true;
forceSSL = true;
locations."/".root = "/var/www";

This comment has been minimized.

@davidak

davidak Jun 1, 2020 Member

this still needs content

This comment has been minimized.

@garbas

garbas Jun 3, 2020 Author Contributor

I don't have a clear idea how to make this have content while not complicating too much.

We can improve or replace this example in next PRs. I still think the example gets the message across even if nothing is being served from /var/www

This comment has been minimized.

@davidak

davidak Jun 3, 2020 Member

can nginx even start when it is missing?

you could serve the nginx default page like debian does after installing nginx package

https://github.com/davidak/nixos-config/blob/02f09fafaa306aff83e61b7d36fcc1dc0fb476bf/machines/web/configuration.nix#L127-L130

@davidak
Copy link
Member

davidak commented Jun 1, 2020

@Mic92
Copy link
Contributor

Mic92 commented Jun 2, 2020

It looks very bad on small screens (mobile) Screenshot_20200531-015325_Firefox_Klar Screenshot_20200531-015942_Firefox_Klar Screenshot_20200531-020014_Firefox_Klar

Looks like mainly the video needs to be made responsive. The rest looks fine.

@davidak
Copy link
Member

davidak commented Jun 2, 2020

Looks like mainly the video needs to be made responsive. The rest looks fine.

yes. i commented on the that change by e-mail. got a little messed up.

also search field and code

@garbas
Copy link
Contributor Author

garbas commented Jun 3, 2020

@davidak

it's too fast!!! i can't read that fast. it's already gone when i have read half of the sentences.

give people some time to read and understand

I don't think video is going to fast. I asked few who told me that the video is having the right speed and if it would be going slower they would lose the interest. Also if they want it to go slower they can pause the video.

But as I said I only asked handful of people. I think going out with the proposed speed is ok and we can listen for the feedback. In any case since the whole video is scripted we just need to increase the value.

If you think this is a blocker, please test it and provide new "--step" value and upload the video to asciinema.org in order for use to compare the two.

It looks very bad on small screens (mobile)

  • asciinema videos don't scale automatically, there are few ways how to do it, but none is optimal. having a terminal on the mobile is hard. Also asciinema "cuts" the videos. You can see the full terminal if you watch it in landscape mode. I wouldn't block on this, but come back to it with solutions.
  • examples also don' scale at this moment, can/should we make them. maybe? either we make the example not readable or we just let the "console" part be left-right scrollable. I wouldn't block because of this, but we definitely need to fix it soon.
  • search box should be easy to fix. Thank you for noticing.
@davidak
Copy link
Member

davidak commented Jun 3, 2020

I wouldn't block because of this, but we definitely need to fix it soon.

yes, it's good for now :)

@github-actions
Copy link

github-actions bot commented Jun 3, 2020

@edibopp
edibopp approved these changes Jun 3, 2020
Copy link
Contributor

edibopp left a comment

Looks good to me apart from the typos. I'd say merge it ;)

<div class="span6">
<h2>Minimal docker image</h2>
<p>
Using <code>Dockefile</code> you are responsible to:

This comment has been minimized.

@edibopp

edibopp Jun 3, 2020 Contributor

Should be Dockerfile

<li>decide how to split into layers for better caching</li>
</ul>
<p>
Writing <code>Dockefile</code> that would produce a minimal image is

This comment has been minimized.

@edibopp

edibopp Jun 3, 2020 Contributor

also Dockerfile

@garbas garbas merged commit b43251e into master Jun 3, 2020
1 check passed
1 check passed
build-and-deploy
Details
@garbas garbas deleted the landing-page branch Jun 3, 2020
@garbas
Copy link
Contributor Author

garbas commented Jun 3, 2020

@davidak @edibopp sorry, i merged to quickly. I'm addressing you concerns in separate PR immediately #434 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants
You can’t perform that action at this time.