Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add footer #426

Merged
merged 2 commits into from May 22, 2020
Merged

Add footer #426

merged 2 commits into from May 22, 2020

Conversation

@garbas
Copy link
Contributor

garbas commented May 13, 2020

@davidak I only provided some structure and style. It is a start and we can start adding links to the footer.

Fixes #361
Closes #358

@davidak davidak force-pushed the footer branch from 5d4e26a to 817bc5c May 22, 2020
@davidak davidak changed the title Footer Add footer May 22, 2020
@samueldr
Copy link
Member

samueldr commented May 22, 2020

The background is cut early left and right on narrow viewports (e.g. phone sizes).

As this is caused by the body's padding, margin-left: -20px; margin-right: -20px will be required with the appropriate media query, in addition to setting padding-left: 20px; padding-right: 20px; in the same media query, to give the expected padding.

@davidak
Copy link
Member

davidak commented May 22, 2020

@samueldr thanks for pointing out. i see the body's padding comes from bootstrap. i figure it out

@davidak davidak force-pushed the footer branch from 817bc5c to c418152 May 22, 2020
@davidak davidak force-pushed the footer branch from c418152 to 81aae57 May 22, 2020
@garbas
Copy link
Contributor Author

garbas commented May 22, 2020

💯

@garbas garbas merged commit 145db53 into master May 22, 2020
1 check passed
1 check passed
build-and-deploy
Details
@garbas garbas deleted the footer branch May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.