Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix comma-separated list on /learn.html #427

Merged
merged 1 commit into from May 18, 2020
Merged

Conversation

@lukegb
Copy link

lukegb commented May 17, 2020

The comma separated lists are really a display concern, and not a
markup concern - in particular, they're semantically lists.

In addition, laying them out like this means it's easy to forget
to put a trailing comma at the end of the line, like is present on
nixos.org/learn.html at the moment (which currently has:
"[Python], [Ruby] [Java], [Go], [Rust], " - note the missing comma
between "Ruby" and "Java").

Luke Granger-Brown
The comma separated lists are really a display concern, and not a
markup concern - in particular, they're semantically lists.

In addition, laying them out like this means it's easy to forget
to put a trailing comma at the end of the line, like is present on
nixos.org/learn.html at the moment (which currently has:
"[Python], [Ruby] [Java], [Go], [Rust], "...).
@garbas
Copy link
Contributor

garbas commented May 18, 2020

Thank you.

@garbas garbas merged commit f5483c6 into NixOS:master May 18, 2020
1 check passed
1 check passed
build-and-deploy
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.