Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

index: do not use IDs for styles #491

Merged
merged 1 commit into from Jun 29, 2020
Merged

index: do not use IDs for styles #491

merged 1 commit into from Jun 29, 2020

Conversation

@samueldr
Copy link
Member

samueldr commented Jun 27, 2020

The unused IDs were removed.

Fix #489

Note that I haven't removed the use of IDs for other parts. They are probably are not causing conflicts. In the future rework of the site, we'll have to be more mindful and use something like rscss. And anyway they are pretty well scoped so the risks are quite small.

The unused IDs were removed.

Fix #489
@garbas
garbas approved these changes Jun 29, 2020
@garbas garbas merged commit 5bc51f7 into master Jun 29, 2020
1 check passed
1 check passed
build-and-deploy
Details
@garbas garbas deleted the fix/489-styles-leaking branch Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.