Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
redesign: misc. fixes for asciinema panes #532
We discussed about:
The first two are implemented. See the new custom event for that.
Smooth scrolling using
My personal experience with sites that scroll smoothly like that is that it's not ever needed, and most of the time feels wrong. For something I'm not entirely sure is needed.
I'll be leaving the decision for smooth scrolling to you, and I'll implement it if desired. Though it's back at the end of the queue for priorities for the time being. It would take a bunch of time to decide on the better library to use, time I prefer to use to implement the rest of the pages as MVPs.
I don't like that the background is just grey. It feels like it opens in a new tab and i'm not on the same page anymore.