Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redesign: Implements last MVPs #533

Merged
merged 26 commits into from Sep 17, 2020
Merged

Conversation

@samueldr
Copy link
Member

samueldr commented Sep 16, 2020

This implements the following pages

  • Download
  • Learn
  • Manuals (includes nix pills)

While for the download page it looks like a lot of work has been done for the looks, don't be deceived!

This is only the exact same DOM as the tabs from the donate page. Oh wait, look at the donate page, it's also much better than the previous structural-only implementation of the tabs, @davidak!

So yeah, this was the plan all along, add basic "yes this is a tab" styles in the previous PR, but actually implement what the mockups had for tabs.

Mockup for reference

image

Like how a good carpet can tie the whole room together, a simple and judicious application of styles sure can transform the downloads page!

samueldr added 7 commits Sep 16, 2020
One of the variable was accidentally a global.
I don't know how else to characterise that in the DOM that would be more
semantic :/
Note that a well is a specialized "semantic~ish" notice-box.
Otherwise with left-leaning navigation, the repeated text is quite
problematic.
@samueldr samueldr marked this pull request as draft Sep 16, 2020
@samueldr samueldr added the re-design label Sep 16, 2020
@davidak
Copy link
Member

davidak commented Sep 16, 2020

I think there is not enough differentiation between the menu element and the box. It has the same color and shape. In the mockup, the box is grey, so less prominent. The visitor is visually guided to the menu.

Screenshot from 2020-09-16 15-38-33

I like the layout of having the manu on the left and content on the right. Feels more natural than the actual tabs before.

I noticed, that on this page are 2 sections, Nix and NixOS, but the site title is Get Nix and a H2 is NixOS. The site tetle should probably be "Download Nix or NixOS" and there should be 2 H2 "Getting Nix" and "Getting NixOS".

Screenshot from 2020-09-16 15-32-04

The selected menu entry has a white background, like the site background. That destroys the shape. That's probably a bad thing to do. Maybe using the blue is already better. But it seems also not perfect to me.

Screenshot from 2020-09-16 15-47-54

Also the black (terminal) feels too heavy on the page. All other colors are very light on the page.

This is my terminal on a white background:

Screenshot from 2020-09-16 15-56-12

It is a transparent dark grey. #373737

Screenshot from 2020-09-16 16-00-00

Maybe we have a dark grey in the new color palette?

samueldr and others added 4 commits Sep 16, 2020
…ure/2020-r/last-mvps
Copy link
Member

davidak left a comment

looks good
haven't checked the code

@garbas
garbas approved these changes Sep 17, 2020
Copy link
Contributor

garbas left a comment

@samueldr awesome work 🥇

@garbas
Copy link
Contributor

garbas commented Sep 17, 2020

I'm going to merge this and we can fix the rest in separate PRs

@garbas garbas marked this pull request as ready for review Sep 17, 2020
@garbas garbas merged commit 4b3035a into feature/2020-redesign Sep 17, 2020
2 checks passed
2 checks passed
build-and-deploy
Details
Netlify Netlify deployment
Details
@garbas garbas deleted the feature/2020-r/last-mvps branch Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.