Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Governance and Donate page redesign #588

Merged
merged 44 commits into from Oct 22, 2020
Merged

Governance and Donate page redesign #588

merged 44 commits into from Oct 22, 2020

Conversation

@garbas
Copy link
Contributor

@garbas garbas commented Sep 28, 2020

Goverance page

Design

TODO

  • "Learn more" link in RFC process section should be green button (@garbas)
  • new image for rfc process, recreate in inkscape (@samueldr)
  • ‼️ dark blue diagonal background for Teams section (@samueldr)
  • icons for teams (need export from the design @garbas)
  • design team listing, font and green button (@garbas)
  • add "NixOS foundation" logo missing in mission statement (@samueldr)
  • design listing of board members as in design (@garbas)
  • design Team pages (@garbas)

Donate page

Design

TODO

  • ‼️ vertical "NixOS Foundation" logo, needs some inkscape work (@samueldr)
  • diagonal light blue background for stores section (@samueldr)
  • image of some fictional character wearing NixOS t-shirt (designer via @garbas)
  • add both stores to the store section (@garbas)
  • prepare text for open collective (@garbas)
  • 3 columns for sponsors in Acknowledgements section, also size of images should be the same (@garbas)

This change is Reviewable

@garbas garbas added the design label Sep 28, 2020
@github-actions
Copy link

@github-actions github-actions bot commented Sep 28, 2020

@garbas garbas changed the title donate.html: initial structure and text WIP: Donate page redesign Sep 28, 2020
@github-actions
Copy link

@github-actions github-actions bot commented Sep 28, 2020

@github-actions
Copy link

@github-actions github-actions bot commented Sep 28, 2020

@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Oct 5, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/marketing-team-meeting-minutes-14/9304/1

@github-actions
Copy link

@github-actions github-actions bot commented Oct 13, 2020

@github-actions
Copy link

@github-actions github-actions bot commented Oct 13, 2020

@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Oct 13, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/hello-tux-shirts/7979/15

and add, but comment out HelloTux shop
samueldr added 2 commits Oct 20, 2020
With text replacement, that text ends up being the *semantic* text. This
is not like alt text where you would have the screen reader describe
that it is attached to an image.
@samueldr
Copy link
Member

@samueldr samueldr commented Oct 20, 2020

‼️ The foundation logo has been implemented in #589

@garbas garbas changed the title Donate page redesign Governance and Donate page redesign Oct 20, 2020
@garbas
Copy link
Contributor Author

@garbas garbas commented Oct 20, 2020

I merge #589 and master ... we have only few things left to finish this PR.

@github-actions
Copy link

@github-actions github-actions bot commented Oct 20, 2020

@samueldr
Copy link
Member

@samueldr samueldr commented Oct 20, 2020

icons for teams (need export from the design @garbas)

Are the icons from the PDF not okay? If they are I can try extracting them, chances are it'll work just fine since it's not a complicated bit in the PDF.

Yes the icons are good from the PDF just I don't know how to extract them.

Good, I'll handle exporting them at the very least.

The gist of it is importing the PDF in inkscape, it will generally handle things fine. Though sometimes it requires a bit of cleanup for things like reducing the amount of points by "simplifying" the paths, and such, so the files end up smaller. Ideally, one would also try to "pixel-snap" lines so they don't end up fuzzy if shown at 1:1 scale.

Names are given in a generic manner as they are not strictly *for* the
governance page.
@samueldr
Copy link
Member

@samueldr samueldr commented Oct 21, 2020

The graphical elements have been extracted, only. They are "face12"'d so they can be coloured with svg.less. If you need more help for them just ask.

They're all exported with 138×138px bounding boxes, so you can apply them to element "centered and contained" and they will be the right scale comparative to each other.

@github-actions
Copy link

@github-actions github-actions bot commented Oct 21, 2020

@github-actions
Copy link

@github-actions github-actions bot commented Oct 21, 2020

Copy link
Member

@davidak davidak left a comment

overall it looks very good. well done!

donate.tt Outdated Show resolved Hide resolved
donate.tt Show resolved Hide resolved
</li>
<li>
<a href="https://www.fastly.com/">
<img src="[% root %]logo/fastly.png" alt="Fastly" />
Copy link
Member

@davidak davidak Oct 22, 2020

the fastly logo is bigger than the box

Screenshot from 2020-10-22 17-55-04

leading to glitches

Screenshot from 2020-10-22 17-55-49

Copy link
Contributor Author

@garbas garbas Oct 22, 2020

@davidak how can I reproduce the glitch?

Copy link
Member

@davidak davidak Oct 22, 2020

open in browser? i mean that the white space around the fastly is not a rectangle like the other, but the corners are cut out, like you see in the screenshot

you see it even more now

Screenshot from 2020-10-22 21-58-38

the images should all have the same 2px(?) border

garbas and others added 3 commits Oct 22, 2020
@github-actions
Copy link

@github-actions github-actions bot commented Oct 22, 2020

@github-actions
Copy link

@github-actions github-actions bot commented Oct 22, 2020

@github-actions
Copy link

@github-actions github-actions bot commented Oct 22, 2020

@github-actions
Copy link

@github-actions github-actions bot commented Oct 22, 2020

@garbas garbas merged commit af6e932 into master Oct 22, 2020
2 checks passed
@garbas garbas deleted the redesign-donate branch Oct 22, 2020
@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Nov 5, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/tweag-nix-dev-update-4/9862/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants