Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Governance page redesign #589

Closed
wants to merge 20 commits into from
Closed

Governance page redesign #589

wants to merge 20 commits into from

Conversation

@garbas
Copy link
Contributor

@garbas garbas commented Sep 28, 2020

Design

TODO

  • "Learn more" link in RFC process section should be green button (@garbas)
  • new image for rfc process, recreate in inkscape (@samueldr)
  • ‼️ dark blue diagonal background for Teams section (@samueldr)
  • icons for teams (need export from the design @garbas)
  • design team listing, font and green button (@garbas)
  • add "NixOS foundation" logo missing in mission statement (@samueldr)
  • design listing of board members as in design (@garbas)
  • design Team pages (@garbas)

This change is Reviewable

@github-actions
Copy link

@github-actions github-actions bot commented Sep 28, 2020

@github-actions
Copy link

@github-actions github-actions bot commented Sep 28, 2020

@garbas garbas added the design label Sep 28, 2020
@github-actions
Copy link

@github-actions github-actions bot commented Sep 28, 2020

@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Oct 5, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/marketing-team-meeting-minutes-14/9304/1

@github-actions
Copy link

@github-actions github-actions bot commented Oct 9, 2020

@github-actions
Copy link

@github-actions github-actions bot commented Oct 9, 2020

@garbas garbas changed the title WIP: Governance page redesign Governance page redesign Oct 12, 2020
@garbas garbas changed the title Governance page redesign WIP: Governance page redesign Oct 12, 2020
@github-actions
Copy link

@github-actions github-actions bot commented Oct 12, 2020

@github-actions
Copy link

@github-actions github-actions bot commented Oct 12, 2020

@github-actions
Copy link

@github-actions github-actions bot commented Oct 12, 2020

@garbas garbas changed the title WIP: Governance page redesign Governance page redesign Oct 13, 2020
@garbas garbas requested a review from samueldr Oct 13, 2020
@github-actions
Copy link

@github-actions github-actions bot commented Oct 13, 2020

@github-actions
Copy link

@github-actions github-actions bot commented Oct 13, 2020

samueldr added 3 commits Oct 20, 2020
The issue comes from a proper SVG having the <?xml > declaration. This
is proper.

What is wrong is having that declaration anywhere else in the document!!

So we're now stripping it from SVG documents being inlined.
Why inline? FONTS!

Otherwise we have to bake in the font outlines as fonts won't follow
through <img /> or background image inclusions.
@github-actions
Copy link

@github-actions github-actions bot commented Oct 20, 2020

@samueldr
Copy link
Member

@samueldr samueldr commented Oct 20, 2020

‼️ dark blue diagonal background for Teams section (@samueldr)

This has been mostly implemented in #588;

I can do the changes if you're not comfortable doing them, once we have that merged in master and master merged in this PR.

@samueldr
Copy link
Member

@samueldr samueldr commented Oct 20, 2020

icons for teams (need export from the design @garbas)

Are the icons from the PDF not okay? If they are I can try extracting them, chances are it'll work just fine since it's not a complicated bit in the PDF.

samueldr added 3 commits Oct 20, 2020
With text replacement, that text ends up being the *semantic* text. This
is not like alt text where you would have the screen reader describe
that it is attached to an image.
@samueldr
Copy link
Member

@samueldr samueldr commented Oct 20, 2020

Given that now #588 lightly depends on this one for the Foundation logo, how should we proceed?

@samueldr samueldr mentioned this pull request Oct 20, 2020
14 tasks
@github-actions
Copy link

@github-actions github-actions bot commented Oct 20, 2020

@garbas
Copy link
Contributor Author

@garbas garbas commented Oct 20, 2020

I'm going to close this PR and merge this work into #588. Then both pages are going to land at the same time

@garbas garbas closed this Oct 20, 2020
@garbas
Copy link
Contributor Author

@garbas garbas commented Oct 20, 2020

icons for teams (need export from the design @garbas)

Are the icons from the PDF not okay? If they are I can try extracting them, chances are it'll work just fine since it's not a complicated bit in the PDF.

Yes the icons are good from the PDF just I don't know how to extract them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants