Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Community page redesign #590

Merged
merged 27 commits into from Oct 13, 2020
Merged

Community page redesign #590

merged 27 commits into from Oct 13, 2020

Conversation

@garbas
Copy link
Contributor

@garbas garbas commented Sep 28, 2020

Design

TODO

  • use blue buttons for "Discourse forum" and "Open webchat" links in Communication section (@garbas)
  • for reddit, discord, twitter use icons and align them in a grid (@garbas)
  • diagonal light blue backround (@samueldr)
  • add short description for past nixcon (@garbas)
  • apply styles for nixcon and adjust to light blue background (@garbas)
  • design style for list of meetups (@garbas)

This change is Reviewable

@github-actions
Copy link

@github-actions github-actions bot commented Sep 28, 2020

@github-actions
Copy link

@github-actions github-actions bot commented Sep 28, 2020

@garbas garbas added the design label Sep 28, 2020
@github-actions
Copy link

@github-actions github-actions bot commented Sep 28, 2020

@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Oct 5, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/marketing-team-meeting-minutes-14/9304/1

@github-actions
Copy link

@github-actions github-actions bot commented Oct 5, 2020

@github-actions
Copy link

@github-actions github-actions bot commented Oct 7, 2020

@github-actions
Copy link

@github-actions github-actions bot commented Oct 8, 2020

@garbas garbas changed the title WIP: Community page redesign Community page redesign Oct 9, 2020
@garbas garbas requested a review from samueldr Oct 9, 2020
@github-actions
Copy link

@github-actions github-actions bot commented Oct 9, 2020

@github-actions
Copy link

@github-actions github-actions bot commented Oct 12, 2020

@github-actions
Copy link

@github-actions github-actions bot commented Oct 12, 2020

samueldr added 2 commits Oct 12, 2020
The NixCon logo basically doubled the size of the generic style sheet.
@github-actions
Copy link

@github-actions github-actions bot commented Oct 12, 2020

@samueldr
Copy link
Member

@samueldr samueldr commented Oct 12, 2020

Quick notes about the ^^^^ previous push


The NixCon logo being embedded that way would pretty much double the general CSS file output size. That's not good.

I added what was already planified: the ability to make page-specific styles. The capability here should be used only for things that increase the main styles by too much. Generally speaking, that will be page-specific assets.


Coupled with that, a white backdrop for the NixCon logo. Since this uses the Nix lambdaflake, and it shouldn't be used against a dark blue backdrop in its blue form, it has been put into a white box. The box emulates the concept presented in the mockup better:

image

Sure, a photo type image would have helped, but it's not something we really have here.

@github-actions
Copy link

@github-actions github-actions bot commented Oct 12, 2020

samueldr added 4 commits Oct 12, 2020
They are not often changed, though they take a while to compile.

At this current commit, it's negligible, but with the upcoming world
asset, it takes quite a while to finish.
Used in the community page
@samueldr
Copy link
Member

@samueldr samueldr commented Oct 13, 2020

The world map asset takes ages to run svgo against (due to the sheer amount of elements).

This is why the assets optimization has been split-off in the last batch of changes.

@github-actions
Copy link

@github-actions github-actions bot commented Oct 13, 2020

samueldr added 3 commits Oct 13, 2020
It can be used to create any kind of angle, of any colour desired.
This uses the multi-purpose wedge to scale a diagonal line.

<div class="columnar-layout -three">
<section class="community-communication">
<h1>Where to talk?</h1>
Copy link
Member

@samueldr samueldr Oct 13, 2020

To me, this wording seems weird. Though, I don't really have suggestions.

Copy link
Contributor Author

@garbas garbas Oct 13, 2020

Yeah I'm also struggling to find better title, but is better then "communication". I took this one from https://www.rust-lang.org/community.

Copy link
Member

@samueldr samueldr Oct 13, 2020

I think the main difference here is the question mark.

@github-actions
Copy link

@github-actions github-actions bot commented Oct 13, 2020

@garbas
Copy link
Contributor Author

@garbas garbas commented Oct 13, 2020

@samueldr 💯

@garbas garbas merged commit 3abf390 into master Oct 13, 2020
2 checks passed
@garbas garbas deleted the redesign-community branch Oct 13, 2020
@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Nov 5, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/tweag-nix-dev-update-4/9862/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants