Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
I just took a superficial look, since it is not ready.
The 1. 2. 3. implies you have to do all these steps to sucees. That makes no sense.
We have discussed the white background before.
so the menu item should be called "verify installation script"
does that also have to be removed to have a clean system again?
maybe that should be better documented in the manual und is not a topic for the download page
the $ in the command in selectable
please notice that light orange on dark orange has a bad contrast and is not very readable!
By prefixing `&` we can make styles in a namespace apply according to external selectors. Here `html.with-js &` makes is so that when the selector is expanded, `&` is replaced with the parent selector (`.collapse`), so it ends up being `html.with-js .collapse`. This does have one caveat. The previous implementation would keep the "un-enabled" variant for any collapse not already converted if the code ended up stopping due to a crash. This is not something that we should concern ourselves with, as if it crashes there's more to worry about.
Using `$("<a />")` is perfectly fine. Even `$("<a class='something' />"). But the moment we want to include variable content, prefer using `.attr` rather than hoping the content will not destroy our string's HTML. Sure, we control the DOM, and *it shouldn't happen*. But as we're making this generic enough, we can make it right at the same time. Furthermore, this, in my opinion, removes the cognitive load of reading the escaped and concatenated string. (This is why the double quotes were replaced with single quotes).
This, coupled with the next change, reduces confusion when mentally mapping the model of the collapse. We don't *really* care about titles, we care about the articles. This is basically a useless diversion at this point in time, but when we need to refer to the article in the future, we're already using the article instead of targeting deeply for its title.
With RSCSS, "modifier" class names are prefixed with a dash.
This is helping a bunch with understanding what is going on. Otherwise `-selected` becomes quite overloaded between the "collapsible" behaviour and the "selection" behaviour of the tabs-like navigation.
This fixes issues with collapse and passing *through* viewport widths. The reason is that the activation logic, on load, depended entirely on which view the site was viewed as! With this, we instead rely on the behaviour that activating *all* links is a safe activity.
This helps with synchronization issues by *completely ignoring* actually synchronizing the elements. So the behaviour now synchronizes its view *and* the other view in different manners, depending on what is desired UX-wise. Read the amended comments in the less file, as it describes the new behaviour.
I added an additional commit where we deviate from the palette by making the orange darker. That commit can be dropped from the change set if desired, though since this style is used in body text, especially in the manual, I figure following the recommendations would be better.