Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tf/cache: Redirect HTTP to HTTPS #112

Open
wants to merge 1 commit into
base: master
from

Conversation

@endocrimes
Copy link
Member

endocrimes commented May 23, 2020

Currently cache.nixos.org is available over HTTP and HTTPS. This is subpar for a variety of reasons.

This commit introduces the viewer_protocol_policy of redirect-to-https to ensure that all connections happen over TLS.

Docs: https://www.terraform.io/docs/providers/aws/r/cloudfront_distribution.html#viewer_protocol_policy

Related to: #34

Currently cache.nixos.org is available over HTTP and HTTPS. This is
subpar for a variety of reasons.

This commit introduces the viewer_protocol_policy of redirect-to-https
to ensure that all conncetions happen over TLS.

https://www.terraform.io/docs/providers/aws/r/cloudfront_distribution.html#viewer_protocol_policy
@edolstra
Copy link
Member

edolstra commented Jun 1, 2020

I don't really see a reason to ban unencrypted access. The binary cache is signed either way. Also http is lower-latency than https (e.g. curl http://cache.nixos.org/nix-cache-info takes 0.02s vs 0.05s for https).

@endocrimes
Copy link
Member Author

endocrimes commented Jun 1, 2020

@edolstra that's fair - I mostly filled this when looking through and seeing @grahamc's issue (although HTTPS has advantages beyond just authenticating the packages)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.