Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

20.09 channels #120

Merged
merged 3 commits into from Sep 7, 2020
Merged

20.09 channels #120

merged 3 commits into from Sep 7, 2020

Conversation

@worldofpeace
Copy link
Member

@worldofpeace worldofpeace commented Sep 4, 2020

Ref to past PR #100

@cole-h
Copy link
Member

@cole-h cole-h commented Sep 5, 2020

Should 19.09 also be marked EOL here?

# # when adding a new version, mark the oldest as "not current". New releases should always be current.
# # Channels where `current = false` are marked `end-of-life` on https://status.nixos.org/ and alerting is disabled.

EDIT: Should 19.03 be removed, as well? I don't know how long we want to keep these EOL'd channels on s.no.o.

@worldofpeace
Copy link
Member Author

@worldofpeace worldofpeace commented Sep 5, 2020

@cole-h It sounds like exactly as you've said it, 19.09 should have been marked EOL here and 19.09 should be removed.
If that's not true someone better correct us 😁

@cole-h
Copy link
Member

@cole-h cole-h commented Sep 6, 2020

cc @grahamc as the author and @edolstra as the merger of those instructions: is this indeed what you had in mind?

If so, maybe the comments should be updated (in another PR) to be more actionable/explicit ("when adding a new version, remove the version from 3 releases ago (e.g. for 19.09, remove 18.03) and mark the oldest remaining version as not-current" or something).

@AmineChikhaoui AmineChikhaoui merged commit 894b79f into NixOS:master Sep 7, 2020
@worldofpeace worldofpeace deleted the worldofpeace:20.09 branch Sep 7, 2020
@vcunat
Copy link
Member

@vcunat vcunat commented Sep 8, 2020

status.nixos.org does not seem to be affected by this change so far. Is some deployment step missing?

@cole-h
Copy link
Member

@cole-h cole-h commented Sep 8, 2020

I asked this same question on IRC a bit ago -- @AmineChikhaoui is taking care of it (https://logs.nix.samueldr.com/nixos-dev/2020-09-08#1599586187-1599588570).

Judging by the layout of this repo, s.no.o is hosted on delft / eris, while only bastion was redeployed, I believe.

@vcunat
Copy link
Member

@vcunat vcunat commented Sep 9, 2020

It is there now. I'm puzzled that 19.09 didn't get visually marked as EOL even though I see it in this diff, but that's such a small thing... (EDIT: maybe on the next update of the EOL channels or something?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.