Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cleanUrl and fragment hack #216

Merged
merged 7 commits into from Oct 28, 2020
Merged

Remove cleanUrl and fragment hack #216

merged 7 commits into from Oct 28, 2020

Conversation

@turboMaCk
Copy link
Member

@turboMaCk turboMaCk commented Oct 27, 2020

I just removed the cleanUrl function and updated all the places I found where #disabled fragment was used. I think this is enough to remove the hack. I tested the behavior there are no refreshes going on.

@github-actions
Copy link

@github-actions github-actions bot commented Oct 27, 2020

@github-actions
Copy link

@github-actions github-actions bot commented Oct 27, 2020

@garbas
Copy link
Collaborator

@garbas garbas commented Oct 27, 2020

The hack is not completely removed. In src/Main.elm

Also removing the #disabled from the url now triggers the request to the backend when those links are clicked, which is not the case on master (you can compare it with search.nixos.org).

@garbas garbas self-requested a review Oct 27, 2020
@turboMaCk turboMaCk marked this pull request as draft Oct 28, 2020
@turboMaCk turboMaCk force-pushed the turboMaCk/avoid-fragment-hack branch from f7fc7b0 to d9b790e Oct 28, 2020
@github-actions
Copy link

@github-actions github-actions bot commented Oct 28, 2020

src/Main.elm Show resolved Hide resolved
src/Main.elm Show resolved Hide resolved
@turboMaCk turboMaCk marked this pull request as ready for review Oct 28, 2020
@github-actions
Copy link

@github-actions github-actions bot commented Oct 28, 2020

garbas
garbas approved these changes Oct 28, 2020
Copy link
Collaborator

@garbas garbas left a comment

I just have some naming comments but other then that it looks and works perfectly.

src/Main.elm Outdated Show resolved Hide resolved
src/Main.elm Outdated Show resolved Hide resolved
@github-actions
Copy link

@github-actions github-actions bot commented Oct 28, 2020

@github-actions
Copy link

@github-actions github-actions bot commented Oct 28, 2020

@garbas garbas merged commit 2de4ef3 into master Oct 28, 2020
1 check passed
1 check passed
@github-actions[bot]
build-and-deploy build-and-deploy
Details
@garbas garbas deleted the turboMaCk/avoid-fragment-hack branch Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants