Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a custom attrname analyzer #35

Merged
merged 3 commits into from May 19, 2020
Merged

Conversation

@adisbladis
Copy link
Member

adisbladis commented May 19, 2020

So searching requests from python3Packages.requests can become a cheap prefix search instead of leading wildcard which is horrible for performance.

Without this change you need s3 credentials, even though the bucket is public
@garbas garbas mentioned this pull request May 19, 2020
2 of 4 tasks complete
@adisbladis adisbladis marked this pull request as draft May 19, 2020
adisbladis added 2 commits May 19, 2020
Use pname/pversion to not clash with elasticsearch parsing of version
@adisbladis adisbladis force-pushed the adisbladis:attrname-analyzer branch from b24e6e9 to b9d57bd May 19, 2020
@adisbladis adisbladis marked this pull request as ready for review May 19, 2020
@garbas garbas self-requested a review May 19, 2020
@garbas
garbas approved these changes May 19, 2020
Copy link
Collaborator

garbas left a comment

🥇

@garbas garbas merged commit 042cb40 into NixOS:master May 19, 2020
1 check passed
1 check passed
build-and-deploy
Details
@garbas garbas linked an issue that may be closed by this pull request May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.